-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add state estimation parameters #2590
Conversation
src/translations/en.json
Outdated
"StateEstimationParametersWeightsTabLabel": "Weights", | ||
"StateEstimationParametersQualityTabLabel": "Thresholds", | ||
"StateEstimationParametersLoadboundsTabLabel": "Loadbounds", | ||
"StateEstimationParametersPrincipalObservableZoneLabel": "Principal observable zone", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Estimation on main observable zone"
src/translations/en.json
Outdated
"weightReaProd": "Reactive prod weight", | ||
"weightActLoad": "Active load weight", | ||
"weightReaLoad": "Reactive load weight", | ||
"weightIN": "IN weight", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Null Inj"
And you can omit weight in the preceding lines for the translation ... (to be consistent with french translations)
src/translations/en.json
Outdated
"PAS": "Minimal", | ||
"EXPERT": "Expert", | ||
"DEBUG": "Debug", | ||
"weightV": "Nominal V", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"V"
src/translations/en.json
Outdated
"thresholdActRedundancy": "Threshold active redundancy", | ||
"thresholdReaRedundancy": "Threshold reactive redundancy", | ||
"thresholdNbLostInjections": "Lost injections number", | ||
"thresholdNbInvalidMeasure": "Invalid measures number", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Invalid measurements number"
src/translations/en.json
Outdated
"thresholdNbCriticalMeasure": "Critical measurements number", | ||
"thresholdNbOutBoundsGap": "Out of bounds gaps number", | ||
"thresholdNbIter": "Iteration number", | ||
"thresholdNbLostTransits": "Lost transits number", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Lost flows number"
src/translations/en.json
Outdated
"DEBUG": "Debug", | ||
"weightV": "Nominal V", | ||
"weightActTransit": "Active transit weight", | ||
"weightReaTransit": "Reactive transit weight", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'transit' --> 'flow' (everywhere)
src/translations/en.json
Outdated
"thresholdReaTransit": "Reactive transit threshold", | ||
"StateEstimationParametersDefaultBoundsSection": "Default bounds section by voltage level (affines loads)", | ||
"StateEstimationParametersDefaultFixedBoundsSection": "Default bounds section by voltage level (fixed loads)", | ||
"pmin": "P Min", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Min P"
same for the following lines ...
} | ||
|
||
const LimitReductionsTable: FunctionComponent<LimitReductionsTableProps> = ({ columnsDefinition, tableHeight }) => { | ||
const LimitReductionsTable: FunctionComponent<LimitReductionsTableProps> = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These components are used to define limit reductions in the loadflow parameters and security analysis parameters, and there a now used in the state estimation parameters, but not to define limit reductions : maybe you have to rename them, to be more generic ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed it CustomVoltageLevelTable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests:
- Unable to set a weight value in some weight columns in 'Weights' tab.
For example, setting a positive weight value in 'Active transit' column gives the following error
updateStateEstimationParametersError
Error: HttpResponseError : 500 Internal Server Error, message : JSON parse error: Active transit weight must be positive.
- In 'Weights' tab, setting a value in 'Nominal V' column or in the 'IN weight' column is accepted, but all other empty cell values are replaced with the value '0'
.catch((error) => { | ||
snackError({ | ||
messageTxt: error, | ||
headerId: 'updateStateEstimationParametersError', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation
I've added a default config for weights and validation rules to avoid misleading backend errors. |
src/translations/fr.json
Outdated
"thresholdNbOutBoundsGap": "Pourcentage d'écarts hors norme", | ||
"thresholdNbIter": "Nombre d'itérations", | ||
"thresholdNbLostTransits": "Nombre de transits perdus", | ||
"thresholdOutBoundsGapV": "Tension", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Tension écarts hors norme"
src/translations/fr.json
Outdated
"thresholdOutBoundsGapV": "Tension", | ||
"thresholdOutBoundsGapP": "Transit actif écarts hors norme", | ||
"thresholdOutBoundsGapQ": "Transit réactif écarts hors norme", | ||
"thresholdLostActProd": "Production active", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Production active perdue"
src/translations/fr.json
Outdated
"thresholdOutBoundsGapP": "Transit actif écarts hors norme", | ||
"thresholdOutBoundsGapQ": "Transit réactif écarts hors norme", | ||
"thresholdLostActProd": "Production active", | ||
"thresholdLostReaProd": "Production réactive", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Production réactive perdue"
src/translations/fr.json
Outdated
"thresholdOutBoundsGapQ": "Transit réactif écarts hors norme", | ||
"thresholdLostActProd": "Production active", | ||
"thresholdLostReaProd": "Production réactive", | ||
"thresholdLostActLoad": "Consommation active", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Consommation active perdue"
src/translations/fr.json
Outdated
"thresholdLostActProd": "Production active", | ||
"thresholdLostReaProd": "Production réactive", | ||
"thresholdLostActLoad": "Consommation active", | ||
"thresholdLostReaLoad": "Consommation réactive", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Consommation réactive perdue"
src/translations/fr.json
Outdated
"thresholdLostReaProd": "Production réactive", | ||
"thresholdLostActLoad": "Consommation active", | ||
"thresholdLostReaLoad": "Consommation réactive", | ||
"thresholdActTransit": "Transit actif télémesures perdues", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Transit actif"
src/translations/fr.json
Outdated
"thresholdLostActLoad": "Consommation active", | ||
"thresholdLostReaLoad": "Consommation réactive", | ||
"thresholdActTransit": "Transit actif télémesures perdues", | ||
"thresholdReaTransit": "Transit réactif télémesures perdues", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Transit réactif"
|
No description provided.