Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state estimation parameters #2590

Merged
merged 26 commits into from
Feb 25, 2025
Merged

Add state estimation parameters #2590

merged 26 commits into from
Feb 25, 2025

Conversation

Meklo
Copy link
Contributor

@Meklo Meklo commented Feb 14, 2025

No description provided.

"StateEstimationParametersWeightsTabLabel": "Weights",
"StateEstimationParametersQualityTabLabel": "Thresholds",
"StateEstimationParametersLoadboundsTabLabel": "Loadbounds",
"StateEstimationParametersPrincipalObservableZoneLabel": "Principal observable zone",
Copy link
Contributor

@FranckLecuyer FranckLecuyer Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Estimation on main observable zone"

"weightReaProd": "Reactive prod weight",
"weightActLoad": "Active load weight",
"weightReaLoad": "Reactive load weight",
"weightIN": "IN weight",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Null Inj"

And you can omit weight in the preceding lines for the translation ... (to be consistent with french translations)

"PAS": "Minimal",
"EXPERT": "Expert",
"DEBUG": "Debug",
"weightV": "Nominal V",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"V"

"thresholdActRedundancy": "Threshold active redundancy",
"thresholdReaRedundancy": "Threshold reactive redundancy",
"thresholdNbLostInjections": "Lost injections number",
"thresholdNbInvalidMeasure": "Invalid measures number",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Invalid measurements number"

"thresholdNbCriticalMeasure": "Critical measurements number",
"thresholdNbOutBoundsGap": "Out of bounds gaps number",
"thresholdNbIter": "Iteration number",
"thresholdNbLostTransits": "Lost transits number",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Lost flows number"

"DEBUG": "Debug",
"weightV": "Nominal V",
"weightActTransit": "Active transit weight",
"weightReaTransit": "Reactive transit weight",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'transit' --> 'flow' (everywhere)

"thresholdReaTransit": "Reactive transit threshold",
"StateEstimationParametersDefaultBoundsSection": "Default bounds section by voltage level (affines loads)",
"StateEstimationParametersDefaultFixedBoundsSection": "Default bounds section by voltage level (fixed loads)",
"pmin": "P Min",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Min P"

same for the following lines ...

}

const LimitReductionsTable: FunctionComponent<LimitReductionsTableProps> = ({ columnsDefinition, tableHeight }) => {
const LimitReductionsTable: FunctionComponent<LimitReductionsTableProps> = ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These components are used to define limit reductions in the loadflow parameters and security analysis parameters, and there a now used in the state estimation parameters, but not to define limit reductions : maybe you have to rename them, to be more generic ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed it CustomVoltageLevelTable

Copy link
Contributor

@FranckLecuyer FranckLecuyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests:

  1. Unable to set a weight value in some weight columns in 'Weights' tab.
    For example, setting a positive weight value in 'Active transit' column gives the following error

updateStateEstimationParametersError
Error: HttpResponseError : 500 Internal Server Error, message : JSON parse error: Active transit weight must be positive.

  1. In 'Weights' tab, setting a value in 'Nominal V' column or in the 'IN weight' column is accepted, but all other empty cell values are replaced with the value '0'

.catch((error) => {
snackError({
messageTxt: error,
headerId: 'updateStateEstimationParametersError',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing translation

@Meklo
Copy link
Contributor Author

Meklo commented Feb 24, 2025

I've added a default config for weights and validation rules to avoid misleading backend errors.
For the first draft of this interface we agreed on not altering tables by voltage level structure to limit complexity therefore all fields are now required.

@Meklo Meklo requested a review from FranckLecuyer February 24, 2025 12:36
"thresholdNbOutBoundsGap": "Pourcentage d'écarts hors norme",
"thresholdNbIter": "Nombre d'itérations",
"thresholdNbLostTransits": "Nombre de transits perdus",
"thresholdOutBoundsGapV": "Tension",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Tension écarts hors norme"

"thresholdOutBoundsGapV": "Tension",
"thresholdOutBoundsGapP": "Transit actif écarts hors norme",
"thresholdOutBoundsGapQ": "Transit réactif écarts hors norme",
"thresholdLostActProd": "Production active",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Production active perdue"

"thresholdOutBoundsGapP": "Transit actif écarts hors norme",
"thresholdOutBoundsGapQ": "Transit réactif écarts hors norme",
"thresholdLostActProd": "Production active",
"thresholdLostReaProd": "Production réactive",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Production réactive perdue"

"thresholdOutBoundsGapQ": "Transit réactif écarts hors norme",
"thresholdLostActProd": "Production active",
"thresholdLostReaProd": "Production réactive",
"thresholdLostActLoad": "Consommation active",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Consommation active perdue"

"thresholdLostActProd": "Production active",
"thresholdLostReaProd": "Production réactive",
"thresholdLostActLoad": "Consommation active",
"thresholdLostReaLoad": "Consommation réactive",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Consommation réactive perdue"

"thresholdLostReaProd": "Production réactive",
"thresholdLostActLoad": "Consommation active",
"thresholdLostReaLoad": "Consommation réactive",
"thresholdActTransit": "Transit actif télémesures perdues",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Transit actif"

"thresholdLostActLoad": "Consommation active",
"thresholdLostReaLoad": "Consommation réactive",
"thresholdActTransit": "Transit actif télémesures perdues",
"thresholdReaTransit": "Transit réactif télémesures perdues",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Transit réactif"

@Meklo Meklo requested a review from FranckLecuyer February 25, 2025 09:41
@Meklo Meklo merged commit 0cae539 into main Feb 25, 2025
5 checks passed
@Meklo Meklo deleted the feat/add_stateestim_parameters branch February 25, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants