-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix byFilter deletion network impacts reduction #590
Conversation
… number of substations containing an equipment deletion is upper or equal to collectionThreshold Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on naming/code. Besides that, code and tests OK
src/main/java/org/gridsuite/modification/server/modifications/NetworkStoreListener.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/NetworkStoreListener.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/NetworkStoreListener.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/NetworkStoreListener.java
Outdated
Show resolved
Hide resolved
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code OK !
99fea07
to
0bc6af8
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code OK
Return a unique substation collection impact (
allNetworkImpacted
) when the number of substation containing an equipment deletion is upper or equal tocollectionThreshold