Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix byFilter deletion network impacts reduction #590

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

sBouzols
Copy link
Contributor

Return a unique substation collection impact (allNetworkImpacted) when the number of substation containing an equipment deletion is upper or equal to collectionThreshold

Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on naming/code. Besides that, code and tests OK

@sBouzols sBouzols requested a review from SlimaneAmar February 6, 2025 13:26
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK !

Slimane AMAR added 2 commits February 7, 2025 15:42
Signed-off-by: Slimane AMAR <amarsli@gm0winl104.bureau.si.interne>
Signed-off-by: Slimane AMAR <amarsli@gm0winl104.bureau.si.interne>
@SlimaneAmar SlimaneAmar force-pushed the fix_byFilter_deletion_impacts_reduction branch from 99fea07 to 0bc6af8 Compare February 7, 2025 14:58
Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK

@antoinebhs antoinebhs merged commit 6c238ea into main Feb 7, 2025
4 checks passed
@antoinebhs antoinebhs deleted the fix_byFilter_deletion_impacts_reduction branch February 7, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants