Fix metadata check in interop tests #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The custom-metadata interop tests checks the underlying element is a decoded `.binary` element. This is isn't guaranteed for binary metadata values as the transport may not decode them. The test should instead check that the _binary values_ for the key are as expected. Modifications: - Use `subscript(binaryValues:)` and `subscript(stringValues:)` Result: More correct test
gjcairo
reviewed
Feb 25, 2025
gjcairo
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The custom-metadata interop tests checks the underlying element is a decoded
.binaryelement. This is isn't guaranteed for binary metadata values as the transport may not decode them. The test should instead check that the binary values for the key are as expected.Modifications:
subscript(binaryValues:)andsubscript(stringValues:)Result:
More correct test