pretty_print() should return a string

grpc · Feb 1, 2024 · c18d72f · c18d72f
1 parent 58c9a46
commit c18d72f
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/tests/gamma/csm_observability_test.py b/tests/gamma/csm_observability_test.py
@@ -125,10 +125,11 @@ def from_response(
             points=list(response.points),
         )
 
-    def pretty_print(self):
+    def pretty_print(self) -> str:
         metric = dataclasses.asdict(self)
+        # too much noise to print all data points from a time series
         metric.pop("points")
-        logger.info(yaml.dump(metric, sort_keys=True))
+        return yaml.dump(metric, sort_keys=True)
 
 
 class CsmObservabilityTest(xds_gamma_testcase.GammaXdsKubernetesTestCase):
@@ -218,7 +219,7 @@ def query_metrics(
             metric_time_series = MetricTimeSeries.from_response(
                 metric, time_series[0]
             )
-            metric_time_series.pretty_print()
+            logger.info(metric_time_series.pretty_print())
             results[metric] = metric_time_series
         return results