Skip to content

Commit

Permalink
Fix bug with Gamma Server Runner not showing GCP Logs link
Browse files Browse the repository at this point in the history
This fixes a bug with all the GammaServerRunner subclass not calling the super class KubernetesBaseRunner run() method properly, which causes the variable self.time_start_requested not being set and hence there is never RunHistory logged for the gamma server runner.
  • Loading branch information
stanley-cheung authored and sergiitk committed Jan 26, 2024
1 parent 57cb40f commit fd7d196
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion framework/test_app/runners/k8s/gamma_server_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

from framework.infrastructure import gcp
from framework.infrastructure import k8s
from framework.test_app.runners.k8s import k8s_base_runner
from framework.test_app.runners.k8s import k8s_xds_server_runner
from framework.test_app.server_app import XdsTestServer

Expand Down Expand Up @@ -133,7 +134,7 @@ def run( # pylint: disable=arguments-differ
False,
replica_count,
)
# super(k8s_base_runner.KubernetesBaseRunner, self).run()
k8s_base_runner.KubernetesBaseRunner.run(self)

if self.reuse_namespace:
self.namespace = self._reuse_namespace()
Expand Down

0 comments on commit fd7d196

Please sign in to comment.