Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go control plane #103

Merged
merged 17 commits into from
Aug 2, 2024
Merged

Add Go control plane #103

merged 17 commits into from
Aug 2, 2024

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Jul 8, 2024

Note that the control plane needs to be built from the repository root, as:

docker build . -f docker/go-control-plane/Dockerfile

This is necessary to include to proto files into the build root.

Note that the control plane needs to be built from the
repository root, as:
```
docker build . -f docker/go-control-plane/Dockerfile
```
This is necessary to include to proto files into the build root.
@eugeneo eugeneo requested a review from XuanWang-Amos July 8, 2024 18:29
@eugeneo eugeneo self-assigned this Jul 8, 2024
@eugeneo eugeneo requested review from easwars and removed request for XuanWang-Amos July 8, 2024 19:43
@easwars easwars self-assigned this Jul 9, 2024
Copy link

@easwars easwars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't done a full pass yet. But I thought I'll just send whatever I have for now, and will send more comments when I find time to do a complete pass. Thanks.

Copy link
Contributor Author

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review! Did my best to address the comments.

@easwars easwars removed their assignment Jul 12, 2024
Copy link
Contributor Author

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I did my best to address the comments.

@easwars easwars assigned easwars and unassigned eugeneo Jul 16, 2024
@eugeneo eugeneo requested a review from a team as a code owner July 29, 2024 20:07
@eugeneo eugeneo requested a review from XuanWang-Amos July 29, 2024 20:07
Copy link
Contributor Author

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review. I addressed the comments.

Please note that I am working on this in parallel with #100. It is really difficult to implement changes that span both sides. I would like to check this in with the current proto files and then change the protocol once both components are checked in.

I can not implement final protocol now because I need the Python side (#100) completely setup in this repo to get access to some custom packages.

Copy link
Contributor Author

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! I think it is all coming together. 2 things I would like to point out:

  1. Some comments I did not implement because of YAGNI. I would like to focus on merging the implementation for fallback test and not speculate about the future requirements.
  2. resource.go will be removed after I implement the new API (I need to merge first).

@easwars easwars assigned eugeneo and unassigned easwars Aug 1, 2024
Copy link
Contributor Author

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. Comments addressed.

Copy link
Contributor Author

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Addressed the comments.

@sergiitk sergiitk merged commit 693125c into grpc:main Aug 2, 2024
7 checks passed
@eugeneo eugeneo deleted the go-docker-image branch August 5, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants