-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates resource cleanup script to support gamma resources for Prod #153
base: main
Are you sure you want to change the base?
Updates resource cleanup script to support gamma resources for Prod #153
Conversation
2. supplies frontend_service_name to gamma server runner cleanup
Please link some test runs to make sure it does not break anything. |
Had triggered it from local, since the pipeline gets triggered from grpc/grpc which points to psm-interop's main unless I am mistaken. |
If clean up is part of normal job, you can run an adhoc kokoro job and use |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you. Noticed one thing that should speed up the process.
@AgraVator Oh. And I've noticed the adhoc run link you shared earlier is for a different test, not a cleanup. However, I'm fine with merging it without the test run. The code seems fine, and the rollback should be easy if the cleanup isn't working. |
No description provided.