Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates resource cleanup script to support gamma resources for Prod #153

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AgraVator
Copy link

No description provided.

@AgraVator AgraVator requested a review from a team as a code owner February 17, 2025 09:55
2. supplies frontend_service_name to gamma server runner cleanup
@XuanWang-Amos
Copy link
Collaborator

Please link some test runs to make sure it does not break anything.

@AgraVator
Copy link
Author

AgraVator commented Feb 19, 2025

Please link some test runs to make sure it does not break anything.

Had triggered it from local, since the pipeline gets triggered from grpc/grpc which points to psm-interop's main unless I am mistaken.

@XuanWang-Amos
Copy link
Collaborator

Please link some test runs to make sure it does not break anything.

Had triggered it from local, since the pipeline gets triggered from grpc/grpc which points to psm-interop's main unless I am mistaken.

If clean up is part of normal job, you can run an adhoc kokoro job and use TEST_DRIVER so the test will use your branch, you can find an example command in go/grpc-blr-learnings Run adhoc kokoro job on prod section.

@AgraVator
Copy link
Author

AgraVator commented Feb 21, 2025

Please link some test runs to make sure it does not break anything.

Had triggered it from local, since the pipeline gets triggered from grpc/grpc which points to psm-interop's main unless I am mistaken.

If clean up is part of normal job, you can run an adhoc kokoro job and use TEST_DRIVER so the test will use your branch, you can find an example command in go/grpc-blr-learnings Run adhoc kokoro job on prod section.

Test run link

@sergiitk sergiitk self-requested a review February 27, 2025 03:38
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. Noticed one thing that should speed up the process.

@sergiitk
Copy link
Member

@AgraVator Oh. And I've noticed the adhoc run link you shared earlier is for a different test, not a cleanup. However, I'm fine with merging it without the test run. The code seems fine, and the rollback should be easy if the cleanup isn't working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants