Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudrun: GKE client to cloudrun server test #154

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

eshitachandwani
Copy link
Member

Tests the case where the client is in GKE and the server is running in cloudrun. Verifies that 100 RPCs reach the server correctly and return with the correct response.

@eshitachandwani eshitachandwani requested a review from a team as a code owner February 26, 2025 20:11
# Help.
./run.sh ./bin/run_test_server_cloud_run.py --help

# Run modes.
Copy link

@kannanjgithub kannanjgithub Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these since we are not taking any args. Only have a single run mode without any arg.
Rename the file was well to have cloud_run instead of c6n.

@@ -0,0 +1,102 @@
# Copyright 2024 gRPC authors.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025

{
"group": backend.url,
"balancingMode": "RATE",
"maxRatePerEndpoint": max_rate_per_endpoint,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have these 2 for cloud run backend as well.

@@ -651,6 +736,8 @@ def _execute( # pylint: disable=arguments-differ
)
request.headers[DEBUG_HEADER_KEY] = self.gfe_debug_header
request.add_response_callback(self._log_debug_header)
logger.info("Executing request: %s", request)
logger.info(request.to_json())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this logging, it seems not really related to our changes.

Comment on lines +268 to +269
logger.info("backend service protocol")
logger.info(self.backend_service_protocol)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this logging.

Comment on lines +36 to +41
MESH_NAME = "grpc-mesh"
SERVER_TLS_POLICY_NAME = "server-tls-policy"
CLIENT_TLS_POLICY_NAME = "client-tls-policy"
AUTHZ_POLICY_NAME = "authz-policy"
ENDPOINT_POLICY = "endpoint-policy"
CERTIFICATE_PROVIDER_INSTANCE = "google_cloud_private_spiffe"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem to be unused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants