Gamma tests: redistribute startTestClient wait times #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added the active ADS check in front of the client-server connection check, but we didn't consider where GAMMA test client spends the majority of its time:
GammaXdsKubernetesTestCase.startTestClienthadwait_for_server_channel_ready_timeoutset to 10 minutes beforewait_for_active_ads_timeoutcheck existed, but actual increased wait happens inwait_for_active_ads_timeout.This would cause some of the CSM failures being misclassified as b/296293582 Timeout establishing ADS stream due to IAM/Workload Identity propagation delay.