Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamma tests: redistribute startTestClient wait times #25

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Gamma tests: redistribute startTestClient wait times #25

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe0397c
Gamma tests: redistribute startTestClient wait times
sergiitk Jan 24, 2024
d3923b2
keep wait_for_server_channel_ready_timeout higher
sergiitk Jan 24, 2024
5386cde
Increase wait_for_server_channel_ready_timeout to 9 min
sergiitk Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions framework/xds_gamma_testcase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,15 @@ def startTestClient(
# test suites because they only start waiting after already waited for
# the TD backends to be created and report healthy.
# In GAMMA, these resources are created asynchronously by Kubernetes.
# To compensate for this, we double the timeout for GAMMA tests.
# To compensate for this, we double the timeout for the active ADS
# stream detection in GAMMA tests. Until the mesh is created,
# ADS calls are rejected with "NOT_FOUND: Requested entity was
# not found."
return self._start_test_client(
server_target,
wait_for_server_channel_ready_timeout=datetime.timedelta(
minutes=10
),
wait_for_active_ads_timeout=datetime.timedelta(minutes=10),
# TODO(sergiitk): consider decreasing to 2-3 minutes, since
# the majority of the wait time spent on waiting ADS.
wait_for_server_channel_ready_timeout=datetime.timedelta(minutes=5),
**kwargs,
)