Fix bug with Gamma Server Runner not having GCP Logs link #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanley-cheung
force-pushed
the
fix-gamma-super-run
branch
from
cd63ed8 to
e565937
Compare
sergiitk
force-pushed
the
fix-gamma-super-run
branch
from
e565937 to
fd7d196
Compare
This fixes a bug with all the GammaServerRunner subclass not calling the super class KubernetesBaseRunner run() method properly, which causes the variable self.time_start_requested not being set and hence there is never RunHistory logged for the gamma server runner.
sergiitk
force-pushed
the
fix-gamma-super-run
branch
from
5c81fcf to
c9acc77
Compare
sergiitk
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug with all the
GammaServerRunnersubclass not calling the super classKubernetesBaseRunner'srun()method properly, which causes the variableself.time_start_requestednot being set and hence there is neverRunHistorylogged for the gamma server runner.ref b/298501683