Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with Gamma Server Runner not having GCP Logs link #26

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Fix bug with Gamma Server Runner not having GCP Logs link #26

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d1070f
Fix bug with Gamma Server Runner not showing GCP Logs link
stanley-cheung Jan 24, 2024
c9acc77
Remove the namespace stuff - it's already in the grandparent's run()
sergiitk Jan 26, 2024
411192f
Merge branch 'main' into fix-gamma-super-run
sergiitk Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions framework/test_app/runners/k8s/gamma_server_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

from framework.infrastructure import gcp
from framework.infrastructure import k8s
from framework.test_app.runners.k8s import k8s_base_runner
from framework.test_app.runners.k8s import k8s_xds_server_runner
from framework.test_app.server_app import XdsTestServer

Expand Down Expand Up @@ -134,14 +135,7 @@ def run( # pylint: disable=arguments-differ
False,
replica_count,
)
# super(k8s_base_runner.KubernetesBaseRunner, self).run()

if self.reuse_namespace:
self.namespace = self._reuse_namespace()
if not self.namespace:
self.namespace = self._create_namespace(
self.namespace_template, namespace_name=self.k8s_namespace.name
)
k8s_base_runner.KubernetesBaseRunner.run(self)

# Reuse existing if requested, create a new deployment when missing.
# Useful for debugging to avoid NEG loosing relation to deleted service.
Expand Down
Loading