Add App Net based CSM Observability Test #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ping GMP endpoint in client and server pod curl localhost:9464/metrics during test - This will provide insight into what GMP gets from the OTel plugin before sending metrics to Cloud Monitoring
- But this doesn't work yet. Can't quite figure out what's the exact request URL to use. Tried quite a few combinations and none of them works.
- `enable_csm_observability` is now a constructor parameter for the client runner and the server runner, instead of a `run()` parameter. - If `enable_csm_observability`, we want to do a port forwarding for the `pod_monitoring_port = 9464`, such that we can issue a GET request against it in the CSM test - Added `monitoring_port` and `monitoring_host` as class variable to the client runner and server runner. - Override `_xds_test_server_for_pod` in the `GammaServerRunner` class - Minimize the places where we need to hardcode the port `9464`
- Added a PrometheusLogger class to write the prometheus endpoint log to a separate log file related to logs_subdir - monitoring_port is now stored in XdsTestClient and XdsTestServer rather than the runner - use rpc_host instead of a separate monitoring_host - put the constant DEFAULT_MONITORING_PORT in the KubernetesBaseRunner - fixed requirements.txt and requirements.lock - removed a previous hack is_legit_time_series() - renamed function to ping_prometheus_endpoint instead of referring it as GMP
- Added app_net_csm_observability_test.py that's largely a copy of gamma/csm_observability_test.py - Refactor some flags to be passed to the k8s_xds_server_runner
sergiitk
reviewed
May 13, 2024
| @@ -103,13 +100,14 @@ def __init__( | |||
| namespace_template=namespace_template, | |||
| debug_use_port_forwarding=debug_use_port_forwarding, | |||
| enable_workload_identity=enable_workload_identity, | |||
| enable_csm_observability=enable_csm_observability, | |||
There was a problem hiding this comment.
instead, let's put all this into deployment_args, see
psm-interop/framework/test_app/runners/k8s/k8s_xds_server_runner.py
Lines 34 to 36 in 2eea2ff
sergiitk
pushed a commit
that referenced
this pull request
Jun 6, 2024
- Created a new test `app_net_csm_observability_test.py` that's largely a copy of `gamma/csm_observability_test.py` with some adjustments. - Refactor some flags to be passed to the `k8s_xds_server_runner`. - Use `ServerDeploymentArgs` everywhere This PR was based on top of #33, and a replacement of #72.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app_net_csm_observability_test.pythat's largely a copy ofgamma/csm_observability_test.pywith some adjustmentsThis PR was based on top of #33.
Able to run both tests successfully on gamma-enabled cluster.