Add App Net based CSM Observability Test #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
force-pushed
the
app-net-csm-o11y-2
branch
from
8631e48 to
dbfc419
Compare
|
sergiitk
reviewed
May 25, 2024
sergiitk
force-pushed
the
app-net-csm-o11y-2
branch
from
3389995 to
de01990
Compare
sergiitk
added a commit
that referenced
this pull request
Jun 5, 2024
…ends (#93) Fixes an issue with NEG size and Backend Health waiting logic. This bug has been in the framework from the very beginning, because we never tested the flow with (a) Regional or multizonal cluster, AND (b) a single server. The issue: when GKE cluster has nodes in more than one zone, a NEG for the test server/service is created in each zone. If there's fewer endpoints than zones in the cluster, not every NEG will end up having a server endpoint. Therefore: 1. `wait_for_network_endpoint_group` will fail because it waits for every NEG to have more than 0 endpoints. 2. `wait_for_backends_healthy_status` will fail because NEGs with 0 endpoints will never be marked as healthy. This PR changes the logic of: 1. `wait_for_network_endpoint_group` now waits for a NEG to merely exist in GCP APIs. 2. `wait_for_backends_healthy_status` now accounts for server replica_count and will succeeded as soon as the number of healthy Backends to be greater or equal the number of server replicas. Discovered when debugging #86. Splitting to its own PR.
sergiitk
force-pushed
the
app-net-csm-o11y-2
branch
from
442fdea to
78ed0fe
Compare
sergiitk
force-pushed
the
app-net-csm-o11y-2
branch
from
78ed0fe to
75c4231
Compare
|
sergiitk
approved these changes
Jun 5, 2024
stanley-cheung
force-pushed
the
app-net-csm-o11y-2
branch
2 times, most recently
from
64fcc69 to
75c4231
Compare
sergiitk
reviewed
Jun 5, 2024
sergiitk
reviewed
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app_net_csm_observability_test.pythat's largely a copy ofgamma/csm_observability_test.pywith some adjustments.k8s_xds_server_runner.ServerDeploymentArgseverywhereThis PR was based on top of #33, and a replacement of #72.