Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic/invalid filename? #16

Open
thahmann opened this issue Dec 2, 2021 · 4 comments
Open

Problematic/invalid filename? #16

thahmann opened this issue Dec 2, 2021 · 4 comments
Assignees

Comments

@thahmann
Copy link
Collaborator

thahmann commented Dec 2, 2021

The filename "ontologies/psl_atomic/atomic*.in" seems to cause pull/merge issues (at least on Windows). My suspicion is that the * is misread as a placeholder. Can this be renamed?

@thahmann
Copy link
Collaborator Author

thahmann commented Dec 2, 2021

Because it is not a clif file, it should also be in the /conversion subfolder of psl_atomic

@gruninger
Copy link
Owner

Did we decide on having a separate /conversion subfolder distinct from a /theorems subfolder that in turn contains an /axioms subfolder with the translated CLIF axioms?

@gruninger
Copy link
Owner

but yes, the file atomic*.in needs to be renamed and moved from where it currently resides.

@thahmann
Copy link
Collaborator Author

thahmann commented Dec 2, 2021

I temporarily renamed it to atomic_star.in just so that I can pull/push any commits.

About the subfolders: I'm actually not sure ... at some point that had developed as a de-facto standard because macleod puts all tptp and prover9 conversions by default in the /conversions subfolder and all generated outputs (proofs and models) in a subfolder /output.
But we also wanted to use a /theorems subfolder in addition for storing clif files of theorems. That theorems folder can contain its own /conversions and /output subfolder (i.e. /theorems/conversions and /theorems/output).

But all of this is up for debate ... but probably we want some kind of consistent structure throughout the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants