Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SNAX triggers #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dethodav
Copy link

This PR adds support for using SNAX triggers inside of hveto. This PR is dependent on https://git.ligo.org/detchar/tools/gwtrigfind/-/merge_requests/44 in gwtrigfind.

An example config is as follows:

[DEFAULT]
ifo = H1

[hveto]
snr-thresholds = 7.75, 8.00, 8.50, 9.00, 10.00, 11.00, 12.00, 15.00, 20.00, 40.00, 100.00, 300.00
time-windows = 0.10, 0.20, 0.40, 0.80, 1.00
minimum-significance = 3.0

[segments]
url = https://segments.ligo.org
(ll_HVeto) [derek.davis@ldas-pcdev1 Feb12_snax]$ head config.ini -n50
[DEFAULT]
ifo = H1

[hveto]
snr-thresholds = 7.75, 8.00, 8.50, 9.00, 10.00, 11.00, 12.00, 15.00, 20.00, 40.00, 100.00, 300.00
time-windows = 0.10, 0.20, 0.40, 0.80, 1.00
minimum-significance = 3.0

[segments]
url = https://segments.ligo.org
analysis-flag = %(IFO)s:DMT-ANALYSIS_READY:1
padding = 0, -10

[primary]
channel = %(IFO)s:CAL-DELTAL_EXTERNAL_DQ_0_2048
trigger-generator = snax
snr-threshold = 6.0
frequency-range = 10,1000
read-format = hdf5.snax

[auxiliary]
trigger-generator = snax
frequency-range = 10,1000
read-format = hdf5.snax
channels = H1:ASC-AS_A_DC_NSUM_OUT_DQ_0_1024
  H1:ASC-AS_A_DC_PIT_OUT_DQ_0_1024
  H1:ASC-AS_A_DC_YAW_OUT_DQ_0_1024
  H1:ASC-AS_A_RF36_I_PIT_OUT_DQ_0_1024
  H1:ASC-AS_A_RF36_I_YAW_OUT_DQ_0_1024
  H1:ASC-AS_A_RF36_Q_PIT_OUT_DQ_0_1024
  H1:ASC-AS_A_RF36_Q_YAW_OUT_DQ_0_1024
  H1:ASC-AS_A_RF72_I_PIT_OUT_DQ_0_1024
  H1:ASC-AS_A_RF72_I_SUM_OUT_DQ_0_1024
  H1:ASC-AS_A_RF72_I_YAW_OUT_DQ_0_1024
  H1:ASC-AS_A_RF72_Q_PIT_OUT_DQ_0_1024
  H1:ASC-AS_A_RF72_Q_SUM_OUT_DQ_0_1024
  H1:ASC-AS_A_RF72_Q_YAW_OUT_DQ_0_1024

This runs with the following command: python -m hveto 1423180818 1423183818 --ifo H1 --config-file config.ini

Tagging @jrsmith02

@dethodav
Copy link
Author

@jrsmith02 @areeda @duncanmmacleod what's the procedure for addressing these CI issues? These don't seem due to this MR. Can we merge this even if we don't fix the CI issues?

I am hoping to test out some new tools (based on HVeto) that use SNAX in the near future, so it would be great if we could make progress on this quickly. (I posted a similar message in the related gwtrigfind MR)

@duncanmmacleod
Copy link
Member

@jrsmith02 @areeda @duncanmmacleod what's the procedure for addressing these CI issues? These don't seem due to this MR. Can we merge this even if we don't fix the CI issues?

@dethodav, I am no longer the maintainer of this project, but I hope my opinion still has value. I would not merge any change for which the CI does not pass, and especially if the test suite doesn't even run - you simply have no (independent) validation that the proposed change 'works'.

The actual problem with CI looks (at a first glance) to be because the github actions used in the workflow are out of date, and nobody is maintaining them. I recommend looking into configuring dependabot, an automaton maintained by github that can open PRs to update the versions automatically. See, e.g. gwdetchar/gwdetchar#466.

@areeda
Copy link
Contributor

areeda commented Feb 14, 2025

I'm looking into CI issues.

@eagoetz
Copy link
Member

eagoetz commented Feb 18, 2025

@dethodav Can you please rebase your PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants