insert() cannot fail and should not return a value

Author: hackerb9

m100-decomment.lex

@@ -12,19 +12,22 @@
 
     #include <string.h>
     #include <ctype.h>
-    int insert(int set[], int n);
+    void insert(int set[], int n);
     void print_set(int set[]);
     void print_intersection(int seta[], int setb[]);
 
-    int insert(int set[], int n) {
-	set[0]++;
-	int len=set[0], i=1;
-	for (i=1; i<len; i++) {
-	    if (set[i] > n) break;
-	    if (set[i] == n) { set[0]--; return 0; }
+    /* Insert a number into the set, if it isn't already there. */
+    /* Minor optimization: start at the end of the array since it is sorted. */
+    void insert(int set[], int n) {
+	int i, len=set[0];
+	for (i=len; i>0; i--) {
+	    if (set[i] == n) return;
+	    if (set[i] < n) break;
 	}
-	memmove(set+i+1, set+i, (len-i)*sizeof(set[0]));
+        i++;
+	memmove(set+i+1, set+i, len*sizeof(set[0]));
 	set[i] = n;
+	set[0]++;
     }
 
  /* Define states that simply copy text instead of lexing */  

m100-jumps.lex

@@ -37,7 +37,7 @@ LINERANGE	{LINENUM}?[ \t]*-[ \t]*{LINENUM}?
     int parse_linelist(char *);
     int parse_linerange(char *);
     int parse_erl(char *);
-    int insert(int set[], int n);
+    void insert(int set[], int n);
     void print_set(int set[]);
     void print_intersection(int seta[], int setb[]);
 
@@ -50,10 +50,10 @@ LINERANGE	{LINENUM}?[ \t]*-[ \t]*{LINENUM}?
 
     /* Insert a number into the set, if it isn't already there. */
     /* Minor optimization: start at the end of the array since it is sorted. */
-    int insert(int set[], int n) {
+    void insert(int set[], int n) {
 	int i, len=set[0];
 	for (i=len; i>0; i--) {
-	    if (set[i] == n) return 0;
+	    if (set[i] == n) return;
 	    if (set[i] < n) break;
 	}
         i++;