Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSockets sometimes (most of the time) don't work #265

Closed
Groovin-Dev opened this issue May 23, 2024 · 1 comment · Fixed by #266
Closed

WebSockets sometimes (most of the time) don't work #265

Groovin-Dev opened this issue May 23, 2024 · 1 comment · Fixed by #266
Labels
bug Something isn't working

Comments

@Groovin-Dev
Copy link

Describe the bug
Any use of Fluxzy as a proxy seems to break some WebSocket connections.

Describe the tool and the environment
I have had the issue with Fluxzy.Core and Fluxzy.Desktop

To Reproduce
Steps to reproduce the behavior:

  1. Run Fluxzy.Desktop or Fluxzy.Core (with nothing custom)
  2. Go to https://echo.websocket.org/.ws
  3. You will notice that it's unable to connect.
    image
  4. Disconnect the proxy and refresh
    image

Screenshot
Seems like it's not marking the connection as WS even though it is.
image

Expected behavior
WebSockets should just work like they usually do and the information should be captured. With Fiddler (The desktop version and FiddlerCore) everything works

Additional context
Probably related to #221
@Groovin-Dev Groovin-Dev changed the title WebSockets sometimes (most of the time) don' WebSockets sometimes (most of the time) don't work May 23, 2024
haga-rak added a commit that referenced this issue May 23, 2024
@haga-rak
Force PoolBuilder to create a new connection when incoming request …
251c9c4 
…is a websocket upgrade #265
@haga-rak haga-rak added the bug Something isn't working label May 23, 2024
@haga-rak haga-rak mentioned this issue May 23, 2024
Merged
@haga-rak haga-rak linked a pull request May 23, 2024 that will close this issue
Fix outstanding bug when initiating ws channel with an existing H11/H2 connection #266
Merged
haga-rak added a commit that referenced this issue May 23, 2024
@haga-rak
Fix outstanding bug when initiating ws channel with an existing H11/H…
18fadd3 
…2 connection (#266)

* Force `PoolBuilder` to create a new connection when incoming request is a websocket upgrade #265

* Add unit tests for websocket and H11 request overlapping
@haga-rak
Copy link
Owner

Thank you for taking the time to provide feedback. I was able to reproduce the issue easily with what you provided.

There is a fix available for Fluxzy.Core in the latest alpha version on nuget.org (currently validating 1.26.2-alpha). This will likely be merged into the next main version after further testing.

If you wish to have the fix early in Fluxzy Desktop, you can overwrite the Fluxzy.Core DLL in the application data; it's currently using the stock version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@haga-rak @Groovin-Dev