From b8472bfdd05de06c3f273830f509c118e4cc434b Mon Sep 17 00:00:00 2001 From: Logan Nguyen Date: Thu, 11 Jul 2024 16:16:19 -0400 Subject: [PATCH] fix: removed unnecessary test cases Signed-off-by: Logan Nguyen --- packages/relay/tests/lib/eth/eth_call.spec.ts | 36 +------------------ .../lib/eth/eth_sendRawTransaction.spec.ts | 2 +- 2 files changed, 2 insertions(+), 36 deletions(-) diff --git a/packages/relay/tests/lib/eth/eth_call.spec.ts b/packages/relay/tests/lib/eth/eth_call.spec.ts index 1e5a9327f7..fc3a3fb25c 100644 --- a/packages/relay/tests/lib/eth/eth_call.spec.ts +++ b/packages/relay/tests/lib/eth/eth_call.spec.ts @@ -118,21 +118,6 @@ describe('@ethCall Eth Call spec', async function () { process.env.ETH_CALL_DEFAULT_TO_CONSENSUS_NODE = 'true'; }); - it('eth_call with missing `to` field', async function () { - await ethCallFailing( - ethImpl, - { - from: CONTRACT_ADDRESS_1, - data: CONTRACT_CALL_DATA, - gas: MAX_GAS_LIMIT_HEX, - }, - 'latest', - (error) => { - expect(error.message).to.equal(`Invalid Contract Address: ${undefined}.`); - }, - ); - }); - it('eth_call with incorrect `to` field length', async function () { await ethCallFailing( ethImpl, @@ -703,31 +688,12 @@ describe('@ethCall Eth Call spec', async function () { expect((result as JsonRpcError).data).to.equal(defaultErrorMessageHex); }); - it('eth_call with missing `to` field', async function () { - const args = [ - { - ...defaultCallData, - from: CONTRACT_ADDRESS_1, - data: CONTRACT_CALL_DATA, - gas: MAX_GAS_LIMIT, - }, - 'latest', - ]; - - await RelayAssertions.assertRejection( - predefined.INVALID_CONTRACT_ADDRESS(undefined), - ethImpl.call, - false, - ethImpl, - args, - ); - }); - it('eth_call with wrong `to` field', async function () { const args = [ { ...defaultCallData, from: CONTRACT_ADDRESS_1, + to: WRONG_CONTRACT_ADDRESS, data: CONTRACT_CALL_DATA, gas: MAX_GAS_LIMIT, }, diff --git a/packages/relay/tests/lib/eth/eth_sendRawTransaction.spec.ts b/packages/relay/tests/lib/eth/eth_sendRawTransaction.spec.ts index 5c2c42cd82..9b07bf06cb 100644 --- a/packages/relay/tests/lib/eth/eth_sendRawTransaction.spec.ts +++ b/packages/relay/tests/lib/eth/eth_sendRawTransaction.spec.ts @@ -126,7 +126,7 @@ describe('@ethSendRawTransaction eth_sendRawTransaction spec', async function () sdkClientStub.submitEthereumTransaction.returns({ txResponse: { - transactionId: TransactionId.fromString(transactionIdServicesFormat), + transactionId: '', }, fileId: null, });