New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCLC numbers are converted to int in a way that is ... probably not right #26

Open

aelkiss opened this issue Jan 29, 2025 · 0 comments

Member

aelkiss commented Jan 29, 2025

hathifiles_database/lib/hathifiles_database/linespec.rb

Lines 65 to 71 in 0939c84

    
           TO_INT = ->(str) do 
        
             begin 
        
               Integer(str, 10) 
        
             rescue 
        
               9999 
        
             end 
        
           end

I didn't see any in the table with OCN 9999, but it implies that OCNs are:

limited to 10 digits max
if they aren't parseable as integers, changed to 9999

That is not how OCNs should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment