optimized errors in prepare command

Author: koertho

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 All notable changes to this project will be documented in this file.
 
+## [1.20.1] - 2023-04-04
+- Changed: more errors on prepare command if something went wrong 
+
 ## [1.20.0] - 2023-03-29
 - Changed: show message in layout when entrypoints not generated
 - Changed: added some english translations

src/Command/PrepareCommand.php

@@ -165,36 +165,37 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         $this->io->text(['', ' // Update encore entry dependencies', '']);
 
-        if (file_exists($this->kernel->getProjectDir().DIRECTORY_SEPARATOR.'package.json')) {
-            $this->io->writeln('Collect encore entry dependencies ');
-            $encorePackageData = [
-                'name' => '@hundh/encore-entry-dependencies',
-                'version' => date('Ymd').'.'.date('Hi').'.'.time(),
-                'dependencies' => $extensionDependencies,
-            ];
-            $encoreAssetsPath = 'vendor'.DIRECTORY_SEPARATOR.'heimrichhannot'.DIRECTORY_SEPARATOR.'encore-entry-dependencies';
-
-            (new Filesystem())->dumpFile(
-                $this->kernel->getProjectDir().DIRECTORY_SEPARATOR.$encoreAssetsPath.DIRECTORY_SEPARATOR.'package.json',
-                json_encode($encorePackageData, \JSON_THROW_ON_ERROR | \JSON_PRETTY_PRINT | \JSON_UNESCAPED_SLASHES)
-            );
-
-            $this->io->writeln('Register dependencies in project');
-            $packageData = json_decode(file_get_contents($this->kernel->getProjectDir().DIRECTORY_SEPARATOR.'package.json'), true);
-
-            $packageData['dependencies'] = array_merge(
-                ['@hundh/encore-entry-dependencies' => 'file:.'.DIRECTORY_SEPARATOR.$encoreAssetsPath.DIRECTORY_SEPARATOR],
-                $packageData['dependencies'] ?? []
-            );
-
-            (new Filesystem())->dumpFile(
-                $this->kernel->getProjectDir().DIRECTORY_SEPARATOR.'package.json',
-                json_encode($packageData, \JSON_THROW_ON_ERROR | \JSON_PRETTY_PRINT | \JSON_UNESCAPED_SLASHES)
-            );
-        } else {
-            $this->io->warning('No package.json could be found in your project. This file must be present for encore to work!');
+        $projectPackageJsonPath = $this->kernel->getProjectDir().DIRECTORY_SEPARATOR.'package.json';
+        if (!file_exists($projectPackageJsonPath)) {
+            throw new \Exception('No package.json could be found in your project. This file must be present for encore to work!');
         }
 
+        $this->io->writeln('Collect encore entry dependencies ');
+        $encorePackageData = [
+            'name' => '@hundh/encore-entry-dependencies',
+            'version' => date('Ymd').'.'.date('Hi').'.'.time(),
+            'dependencies' => $extensionDependencies,
+        ];
+        $encoreAssetsPath = 'vendor'.DIRECTORY_SEPARATOR.'heimrichhannot'.DIRECTORY_SEPARATOR.'encore-entry-dependencies';
+
+        (new Filesystem())->dumpFile(
+            $this->kernel->getProjectDir().DIRECTORY_SEPARATOR.$encoreAssetsPath.DIRECTORY_SEPARATOR.'package.json',
+            json_encode($encorePackageData, \JSON_THROW_ON_ERROR | \JSON_PRETTY_PRINT | \JSON_UNESCAPED_SLASHES)
+        );
+
+        $this->io->writeln('Register dependencies in project');
+        $packageData = json_decode(file_get_contents($projectPackageJsonPath), true, 512, \JSON_THROW_ON_ERROR);
+
+        $packageData['dependencies'] = array_merge(
+            ['@hundh/encore-entry-dependencies' => 'file:.'.DIRECTORY_SEPARATOR.$encoreAssetsPath.DIRECTORY_SEPARATOR],
+            $packageData['dependencies'] ?? []
+        );
+
+        (new Filesystem())->dumpFile(
+            $projectPackageJsonPath,
+            json_encode($packageData, \JSON_THROW_ON_ERROR | \JSON_PRETTY_PRINT | \JSON_UNESCAPED_SLASHES)
+        );
+
         if (!empty($encoreJsEntries)) {
             $this->io->text(['', ' // Output encore_bundles.js', '']);