Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using start and end instead of left and right to support RTL in the calendar. #4007

Open
darkyeg opened this issue Nov 7, 2024 · 2 comments · May be fixed by #4782
Open

Using start and end instead of left and right to support RTL in the calendar. #4007

darkyeg opened this issue Nov 7, 2024 · 2 comments · May be fixed by #4782
Assignees
@wingkwong
Labels
🎨 Scope : Themes / Styles Related to the themes or styles ✨ Type: Enhancement New enhancement on existing codebase

Comments

@darkyeg
Copy link

darkyeg commented Nov 7, 2024

https://github.com/nextui-org/nextui/blob/1091377e4de83221068247ec6411e4af0082665b/packages/core/theme/src/components/calendar.ts#L91-L96
@linear Linear
Copy link

linear bot commented Nov 7, 2024

ENG-1528 "Use `start` and `end` instead of `left` and `right` to support RTL."

@darkyeg darkyeg changed the title "Use start and end instead of left and right to support RTL." Using start and end instead of left and right to support RTL in the calendar. Nov 7, 2024
@RadheyMugdal
Copy link

I’m interested in working on this issue. Would it be okay if I submitted a PR?

@wingkwong wingkwong added ✨ Type: Enhancement New enhancement on existing codebase 🎨 Scope : Themes / Styles Related to the themes or styles labels Jan 31, 2025
@wingkwong wingkwong self-assigned this Feb 1, 2025
@wingkwong wingkwong linked a pull request Feb 1, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wingkwong wingkwong

Labels
🎨 Scope : Themes / Styles Related to the themes or styles ✨ Type: Enhancement New enhancement on existing codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(theme): replace left & right by start & end to support RTL heroui-inc/heroui
3 participants
@wingkwong @darkyeg @RadheyMugdal