Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't rename sensors #49

Open
h8hr1pzdo3rmiqv5 opened this issue Nov 20, 2024 · 1 comment
Open

can't rename sensors #49

h8hr1pzdo3rmiqv5 opened this issue Nov 20, 2024 · 1 comment

Comments

@h8hr1pzdo3rmiqv5
Copy link

Tried the new version 1.0.0 today.

It worked at first, but i renamed the sensors (sensor.cryptoinfo_name_bitcoin_usd_1 to sensor.cryptoinfo_bitcoin_usd, for example) and the sensor aren't updated anymore.
Renamed one back to its original name, and now it's working again.

Having a mandatory identifier is annoying, but that's me. My use case of CryptoInfo is to get rates only (hence the multiplier 1) to set alerts. I initially set up an identifier named "rate", simply. However, i lost the history from versions 0.x.x. Not a big deal.

Having the multiplier in the sensor name is weird, no? As the multiplier is a reflection of one's wallet, it is subject to change. It's not in my use case, but someone having a dashboard of their savings would not find it handy to update every reference to the sensor each time their wallet is changed.

Suggested fix:
either let the entry follow the renamings of its sensors, or
remove the multiplier from the sensor name.

Thank you for your work. It's a useful integration.

@heyajohnny
Copy link
Owner

Having the multiplier in the sensor name is weird, no?

Yeah you have a point there...
In the version I just released (v1.0.1), the multiplier is removed from the identifier.
The problem with renaming the sensor will probably take some more time. I hope to have some time this week. I'll keep you updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants