fix(authorize): added guard functionality

BREAKING CHANGE: now authorize function requires clientId, clientSecret and grantType

Author: hiddenboox

package-lock.json

@@ -7,8 +7,8 @@
   "source": "src/index.js",
   "scripts": {
     "start": "./node_modules/.bin/nodemon --exec babel-node ./src/index.js",
-    "test": "./node_modules/.bin/mocha --require dotenv/config --require @babel/register",
-    "test:watch": "./node_modules/.bin/mocha --require dotenv/config --require @babel/register --watch --watch-extensions js \"test/**/*.js\"",
+    "test": "./node_modules/.bin/mocha --require dotenv/config --require @babel/register --require chai/register-should",
+    "test:watch": "./node_modules/.bin/mocha --require dotenv/config --require @babel/register --require chai/register-should --watch --watch-extensions js \"test/**/*.js\"",
     "build": "./node_modules/.bin/rollup -c",
     "serve": "node ./dist/index.js",
     "debug": "babel-node --inspect-brk ./src/index.js",
@@ -30,25 +30,29 @@
     "@babel/node": "^7.4.5",
     "@babel/preset-env": "^7.4.5",
     "@babel/register": "^7.4.4",
-    "@pika/plugin-build-node": "^0.4.0",
-    "@pika/plugin-standard-pkg": "^0.4.0",
     "builtin-modules": "^3.1.0",
     "chai": "^4.2.0",
+    "cz-conventional-changelog": "^3.1.0",
     "mocha": "^6.1.4",
     "nock": "^10.0.6",
     "nodemon": "^1.19.1",
     "prettier": "1.18.2",
     "rollup": "^1.16.2",
     "rollup-plugin-commonjs": "^10.0.0",
     "rollup-plugin-json": "^4.0.0",
-    "sinon": "^7.3.2",
-    "semantic-release": "^15.13.18"
+    "semantic-release": "^15.13.18",
+    "sinon": "^7.3.2"
   },
   "repository": {
     "type": "git",
     "url": "https://github.com/hiddenboox/gateway-payu.git"
   },
   "publishConfig": {
     "access": "public"
+  },
+  "config": {
+    "commitizen": {
+      "path": "./node_modules/cz-conventional-changelog"
+    }
   }
 }

package.json

@@ -1,7 +1,12 @@
-import { post } from './helpers'
+import { post } from './helpers/request'
 import { environment } from './env'
+import { required } from './helpers/validation'
 
-export default async ({ clientId, clientSecret, grantType }) => {
+export default async ({ clientId, clientSecret, grantType } = {}) => {
+  required('PAYU_CLIENT_ID', clientId)
+  required('PAYU_CLIENT_SECRET', clientSecret)
+  required('grantType', grantType)
+  
   try {
     const response = await post(
       `${environment}/pl/standard/user/oauth/authorize`,

src/authorize.js

@@ -2,12 +2,23 @@ export const ContentType = {
     JSON: 'application/json'
 }
 
+export const HEADERS = {
+    Authorization: 'Authorization',
+    'Content-Type': 'Content-Type'
+}
+
 export const HttpVerb = {
     POST: 'POST',
     GET: 'GET',
 }
 
+export const EnvironmentName = {
+    SANDBOX: 'SANDBOX',
+    PRODUCTION: 'PRODUCTION',
+}
+
 export const Environment = {
-    SANDBOX: 'https://secure.snd.payu.com',
-    PRODUCTION: 'https://secure.payu.com',
-}
+    [EnvironmentName.SANDBOX]: 'https://secure.snd.payu.com',
+    [EnvironmentName.PRODUCTION]: 'https://secure.payu.com',
+}
+

src/consts.js

@@ -1,3 +1,3 @@
-import { Environment } from "./consts"
+import { Environment, EnvironmentName } from "./consts"
 
-export const environment = Environment[(process.env.PAYU_ENVIRONMENT ? process.env.PAYU_ENVIRONMENT : 'sandbox').toUpperCase()] 
+export const environment = Environment[process.env.PAYU_ENVIRONMENT ? process.env.PAYU_ENVIRONMENT : EnvironmentName.SANDBOX] 

src/env.js

@@ -1,7 +1,8 @@
 import querystring from 'querystring'
 import https from 'https'
 import { URL } from 'url'
-import { HttpVerb } from './consts'
+
+import { HttpVerb } from '../consts'
 
 export const request = ({ url, json, params, body, ...rest } = { method: 'GET', json: true }) => {
   const uri = new URL(`${url}${params ? '?' + querystring.stringify(params) : ''}`)
@@ -17,9 +18,9 @@ export const request = ({ url, json, params, body, ...rest } = { method: 'GET',
         resolve(json ? JSON.parse(data) : data);
       });
 
-    }).on("error", (err) => {
+    }).on('error', (err) => {
       console.log(err)
-      reject("Error: " + err.message);
+      reject('Error: ' + err.message);
     })
 
     if (body) {
@@ -30,5 +31,5 @@ export const request = ({ url, json, params, body, ...rest } = { method: 'GET',
   })
 }
 
-export const get = (url, params, options = {}) => request({ url, params, ...options, ...{ method: HttpVerb.GET } })
-export const post = (url, body, options = {}) => request({ url, body, ...options, ...{ method: HttpVerb.POST } })
+export const get = (url, params, options = {}) => request({ ...options, url, params, method: HttpVerb.GET })
+export const post = (url, body, options = {}) => request({ ...options, url, body, method: HttpVerb.POST })

src/helpers.js src/helpers/request.js

@@ -0,0 +1,3 @@
+import assert from 'assert'
+
+export const required = (name, v) => assert.ok(v, `${name} should not be empty`)

src/helpers/validation.js

@@ -1,17 +1,16 @@
-import assert from 'assert'
-
-import { post } from './helpers'
-import { ContentType } from './consts'
+import { post } from './helpers/request'
+import { ContentType, HEADERS } from './consts'
 import { environment } from './env'
+import { required } from './helpers/validation'
 
 const { PAYU_CLIENT_NOTIFY_SITE_URL, PAYU_CLIENT_ID } = process.env
 
-export default async ({ accessToken, payment, cart, buyer, products }) => {
-  assert.ok(accessToken, 'accessToken should not be empty')
-  assert.ok(payment, 'payment should not be empty')
-  assert.ok(cart, 'cart should not be empty')
-  assert.ok(buyer, 'buyer should not be empty')
-  assert.ok(products, 'products should not be empty')
+export default async ({ accessToken, payment, cart, buyer, products } = {}) => {
+  required('accessToken', accessToken)
+  required('payment', payment)
+  required('cart', cart)
+  required('buyer', buyer)
+  required('products', products)
 
   try {
     return await post(
@@ -27,8 +26,8 @@ export default async ({ accessToken, payment, cart, buyer, products }) => {
       {
         json: true,
         headers: {
-          'Authorization': `Bearer ${accessToken}`,
-          'Content-Type': ContentType.JSON,
+          [HEADERS.Authorization]: `Bearer ${accessToken}`,
+          [HEADERS.ContentType]: ContentType.JSON,
         },
       }
     )

src/order.js

@@ -1,5 +1,6 @@
-import 'chai/register-should'
 import nock from 'nock'
+import assert from 'assert'
+import { expect } from 'chai'
 
 import { mockAuthorize } from './server'
 
@@ -26,4 +27,28 @@ describe('authorize function', () => {
     response.should.have.property('expiresIn')
     response.should.have.property('grantType')
   })
+
+  it('should return validation error on PAYU_CLIENT_ID when field is not provided', async () => {
+    try {
+      await authorize()
+    } catch (err) {
+      should.throw(() => { throw err }, assert.AssertionError, 'PAYU_CLIENT_ID should not be empty')
+    }
+  })
+
+  it('should return validation error on PAYU_CLIENT_SECRET when field is not provided', async () => {
+    try {
+      await authorize({ clientId: 2 })
+    } catch (err) {
+      should.throw(() => { throw err }, assert.AssertionError, 'PAYU_CLIENT_SECRET should not be empty')
+    }
+  })
+
+  it('should return validation error on grantType when field is not provided', async () => {
+    try {
+      await authorize({ clientId: 2, clientSecret: 2 })
+    } catch (err) {
+      should.throw(() => { throw err }, assert.AssertionError, 'grantType should not be empty')
+    }
+  })
 })

test/authorize.test.js

@@ -1,4 +1,3 @@
-import 'chai/register-should'
 import nock from 'nock'
 
 import { mockOrder } from './server'

test/order.test.js

@@ -1,10 +1,9 @@
-import 'chai/register-should'
 import nock from 'nock'
 
 import { authorize, order } from '../src'
 import { mockAuthorize, mockOrder } from './server'
 
-const { PAYU_CLIENT_ID, PAYU_CLIENT_SECRET, PAYU_CLIENT_NOTIFY_SITE_URL } = process.env
+const { PAYU_CLIENT_ID, PAYU_CLIENT_SECRET } = process.env
 
 describe('order flow', () => {
   afterEach(() => {