Do not ignore data-enable-help-for-making-changes attribute

hilverd · hilverd · commit 58fc614be47c · 2023-01-17T21:01:09.000Z
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,9 @@ This applies from version 0.5.0 onwards, as some versions before that have broke
 ### Added
 ### Changed
 ### Fixed
+
+- Fix bug: do not ignore the `data-enable-help-for-making-changes` attribute.
+
 ### Removed
 
 ## [1.8.4] - 2022-11-24
diff --git a/glossary.js b/glossary.js
@@ -82,7 +82,7 @@ const app = Elm.ApplicationShell.init({
         glossaryItems: glossaryItems,
         editorIsRunning: editorIsRunning,
         enableHelpForMakingChanges: enableHelpForMakingChanges,
-        enableSavingChangesInMemory: enableSavingChangesInMemory,
+        enableSavingChangesInMemory: true || enableSavingChangesInMemory,
         enableMarkdownBasedSyntax: enableMarkdownBasedSyntax,
     }
 });
diff --git a/src/ApplicationShell.elm b/src/ApplicationShell.elm
@@ -140,6 +140,7 @@ init flags =
                 editorIsRunning
                 (CommonModel
                     filename
+                    enableHelpForMakingChanges
                     enableSavingChangesInMemory
                     CommonModel.Alphabetically
                     Nothing
diff --git a/src/CommonModel.elm b/src/CommonModel.elm
@@ -13,6 +13,7 @@ type OrderItemsBy
 
 type alias CommonModel =
     { filename : Maybe String
+    , enableHelpForMakingChanges : Bool
     , enableSavingChangesInMemory : Bool
     , orderItemsBy : OrderItemsBy
     , maybeIndex : Maybe GlossaryItemIndex
diff --git a/src/Pages/ListAll.elm b/src/Pages/ListAll.elm
@@ -1363,7 +1363,7 @@ view model =
                                             [ text Components.Copy.sandboxModeMessage ]
                                     ]
                                 , viewMakingChangesHelp model.common.filename noModalDialogShown_
-                                    |> Extras.Html.showIf (not model.common.enableSavingChangesInMemory)
+                                    |> Extras.Html.showIf (model.common.enableHelpForMakingChanges && not model.common.enableSavingChangesInMemory)
                                 , h1
                                     [ id ElementIds.title ]
                                     [ text <| GlossaryTitle.toString title ]

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ const app = Elm.ApplicationShell.init({`
`82`	`82`	`glossaryItems: glossaryItems,`
`83`	`83`	`editorIsRunning: editorIsRunning,`
`84`	`84`	`enableHelpForMakingChanges: enableHelpForMakingChanges,`
`85`		`- enableSavingChangesInMemory: enableSavingChangesInMemory,`
	`85`	`+ enableSavingChangesInMemory: true \|\| enableSavingChangesInMemory,`
`86`	`86`	`enableMarkdownBasedSyntax: enableMarkdownBasedSyntax,`
`87`	`87`	`}`
`88`	`88`	`});`
Original file line number	Diff line number	Diff line change
`@@ -1363,7 +1363,7 @@ view model =`
`1363`	`1363`	`[ text Components.Copy.sandboxModeMessage ]`
`1364`	`1364`	`]`
`1365`	`1365`	`, viewMakingChangesHelp model.common.filename noModalDialogShown_`
`1366`		`- \|> Extras.Html.showIf (not model.common.enableSavingChangesInMemory)`
	`1366`	`+ \|> Extras.Html.showIf (model.common.enableHelpForMakingChanges && not model.common.enableSavingChangesInMemory)`
`1367`	`1367`	`, h1`
`1368`	`1368`	`[ id ElementIds.title ]`
`1369`	`1369`	`[ text <\| GlossaryTitle.toString title ]`