Make GlossaryFromDom.applyChanges sort items

Author: hilverd

CHANGELOG.md

@@ -17,6 +17,9 @@ This applies from version 0.5.0 onwards, as some versions before that have broke
 - Upgrade GitHub Actions.
 
 ### Fixed
+
+- When using the `worker.min.js` script, ensure that items are sorted by the IDs of their disambiguated preferred terms.
+
 ### Removed
 
 ## [5.0.2] - 2024-06-21

src/Data/GlossaryFromDom.elm

@@ -362,7 +362,16 @@ applyChanges changes glossaryFromDom =
             |> (\result ->
                     case result of
                         Ok result_ ->
-                            ChangesApplied result_
+                            let
+                                sortedItems =
+                                    result_
+                                        |> Tuple.second
+                                        |> .items
+                                        |> List.sortBy GlossaryItemFromDom.disambiguatedPreferredTermIdString
+                            in
+                            result_
+                                |> Tuple.mapSecond (\glossaryFromDom_ -> { glossaryFromDom_ | items = sortedItems })
+                                |> ChangesApplied
 
                         Err err ->
                             LogicalErrorWhenApplyingChanges err

tests/Data/GlossaryFromDomTests.elm

@@ -171,12 +171,12 @@ suite =
                                         , gardeningDescribedTagFromDom
                                         ]
                                     , items =
-                                        [ { defaultComputerScienceItemFromDom
-                                            | disambiguationTag = Just financeRawTag
-                                          }
-                                        , { defaultFinanceItemFromDom
+                                        [ { defaultFinanceItemFromDom
                                             | disambiguationTag = Just computerScienceRawTag
                                           }
+                                        , { defaultComputerScienceItemFromDom
+                                            | disambiguationTag = Just financeRawTag
+                                          }
                                         , { informationRetrievalItemFromDom
                                             | normalTags = [ financeRawTag ]
                                           }