Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger Vercel docs build when a new release is deployed #103

Closed
rafaelcr opened this issue Jun 20, 2023 · 6 comments · Fixed by hirosystems/stacks-blockchain-api#1787
Closed
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@rafaelcr
Copy link
Collaborator

so docs can be updated without the need for a manual Vercel build

@rafaelcr rafaelcr added the documentation Improvements or additions to documentation label Jun 20, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Ordinals Jun 20, 2023
@LakshmiLavanyaKasturi
Copy link
Contributor

This is dependent on the decision made for remote docs - hirosystems/docs#356. @rafaelcr @CharlieC3

@CharlieC3
Copy link
Member

@LakshmiLavanyaKasturi Is this still needed? Can it be closed?

@LakshmiLavanyaKasturi
Copy link
Contributor

I see an issue with the build cache. It looks like, Netlify is picking the old cache, and the deployment still fails after refreshing the build using the "redeploy" button from Vercel.

Eg, In the PR: hirosystems/docs#401, there were remote file changes, and I tried to use "redeploy" from Vercel to pull the remote changes. However, the Vercel and Netlify deployments failed as they showed the old cache.

When I pushed a new commit to the branch, the deployment was successful. @CharlieC3

@chresko
Copy link

chresko commented Aug 14, 2023

@LakshmiLavanyaKasturi Can this be closed? Thanks!

@rafaelcr
Copy link
Collaborator Author

rafaelcr commented Oct 9, 2023

We should still write this automation. Now that we have automatic OpenAPI updates in the docs repo (thanks to hirosystems/docs#525), we should just make sure that whenever a release is made in any API that we trigger the docs Vercel build again so the new API definitions are refreshed automatically.

@CharlieC3
Copy link
Member

@rafaelcr I submitted three PRs to address this here:
hirosystems/stacks-blockchain-api#1787
#285
hirosystems/token-metadata-api#192

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Ordinals Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants