From c01ce2d65642c9d11ad411c573ad3cb43d71e0f2 Mon Sep 17 00:00:00 2001 From: Matthias Viehweger Date: Tue, 17 Dec 2024 19:12:16 +0100 Subject: [PATCH] Remove unneeded disabling of an unused callback --- app/models/group/root.rb | 4 ---- app/models/nejb_role.rb | 4 ---- spec/models/nejb_role_spec.rb | 4 ---- 3 files changed, 12 deletions(-) diff --git a/app/models/group/root.rb b/app/models/group/root.rb index 4f9d85a2..896d778f 100644 --- a/app/models/group/root.rb +++ b/app/models/group/root.rb @@ -13,10 +13,6 @@ class Admin < ::Role self.permissions = [:layer_and_below_full, :admin] self.two_factor_authentication_enforced = true - def skip_alumnus_callback - true - end - def alumnus_manager @alumnus_manager ||= Jubla::Role::NullAlumnusManager.new end diff --git a/app/models/nejb_role.rb b/app/models/nejb_role.rb index 20334d53..19d9e100 100644 --- a/app/models/nejb_role.rb +++ b/app/models/nejb_role.rb @@ -7,10 +7,6 @@ class NejbRole < Role module AlumnusFreeRole - def skip_alumnus_callback - true - end - def alumnus_manager @alumnus_manager ||= Jubla::Role::NullAlumnusManager.new end diff --git a/spec/models/nejb_role_spec.rb b/spec/models/nejb_role_spec.rb index 93b25976..25677555 100644 --- a/spec/models/nejb_role_spec.rb +++ b/spec/models/nejb_role_spec.rb @@ -14,10 +14,6 @@ expect(subject).to be_a Jubla::Role end - it "disables the alumnus-callback" do - expect(subject.skip_alumnus_callback).to be_truthy - end - it "uses the NullAlumnusManager" do expect(subject.alumnus_manager).to be_a Jubla::Role::NullAlumnusManager end