Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix type marking in MemoryEditInjectPhase #5

Open
holly-hacker opened this issue Nov 27, 2017 · 2 comments
Open

Fix type marking in MemoryEditInjectPhase #5

holly-hacker opened this issue Nov 27, 2017 · 2 comments

Comments

@holly-hacker
Copy link
Owner

Calling name.Analyze on one of the types returned from the type injection results in a null reference exception somewhere in VTable analyzer code.

@holly-hacker
Copy link
Owner Author

I just realized that you shouldn't be renaming an override methods, which ToString() is. I'll have to add a check and only rename non-overrides.

While I'm at it, I shouldn't be injecting the ToString() method in the first place on non-debug builds, so I'll have to put it in an #if DEBUG directive.

@holly-hacker
Copy link
Owner Author

holly-hacker commented Dec 3, 2017

Ignoring all virtual & public methods should fix it, but it reveals another issue: ConfuserEx doesn't seem to update the references to renamed fields/properties.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant