-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new icons for snapshot, restore and clear tools #130
Comments
Hmm; those are tricky concepts to convey. I'll think about those... |
My two cents: In reality, the checkpoint is setting the current point as a checkpoint. Which makes me think of just the check mark by itself. The restore button will be going back to the previous check point, which makes me think of the check mark with the arrow going backward (your checkpoint icon). |
But I do see value in the two being visually related... |
The direction of the arrows was to match the undo and redo direction (which is where I got the arrows), but sure, one could just have a check and a restore icon: The right-facing arrow makes a nicer graphic design than this left one, but either is fine with me. I'll leave it up to Philipp. |
I'm not at all the authority on this, just stating my personal opinion :) @kajiglet may want to weigh in |
@jbednar Where can I find the full suite of existing icons to get a overall feel? I agree that the right-facing arrow would be nicer, however the direction is important since restoring returns the state to an older checkpoint. |
The camera icon makes sense with snapshot, but I'd worry that it would be confusing with the save tool (currently a floppy disk icon, as if that meant something to the kids these days!), since that too is a kind of snapshot. Anyway, I have no strong preference between any of them, so maybe leave it up to @bryevdv. |
Visual design is not a strength of mine. My only ideas are that the snapshot tool evidently saves something like a table, so perhaps if it's possible to represent a table in an icon that might be a good choice. Then the table could have a little ✖️ or ✔️ in the corner for the restore/clear versions? And then if all that is possible, the save tool could be changed to the camera (agree that a floppy disk is getting anachronistic, I haven't used one personally in ~15 years) |
I'm happy to submit a PR to replace the snapshot tool's icon with a camera. :-) I guess even cameras are anachronistic by this point, but arguably so is anything with a physical form that reflects its function! @philippjfr, how does the clear tool relate to the checkpoint and restore tools? I had been thinking it was separate, in that it doesn't involve the stack of saved state, just the current state, but I guess in each case it's about the state of an object -- clearing it, saving it, and restoring it? Do they each work on one particular CDS, or does clear clear all drawing objects? In any case, "Table" (presumably like So maybe the store can be represented by a stack, like It's a bit abstract, but seems accurate, at least if my understanding of how the three tools relate to each other is correct. |
Let's implement the camera icons for the EarthSim annotators using the customizable icon method (so we don't need to do a Bokeh PR). |
This repo now contains three new bokeh tools which each should get a new icon:
The text was updated successfully, but these errors were encountered: