Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new icons for snapshot, restore and clear tools #130

Open
philippjfr opened this issue Jun 25, 2018 · 15 comments
Open

Create new icons for snapshot, restore and clear tools #130

philippjfr opened this issue Jun 25, 2018 · 15 comments
Assignees
Milestone

Comments

@philippjfr
Copy link
Contributor

This repo now contains three new bokeh tools which each should get a new icon:

  1. Snapshot tool: Saves a snapshot of the current state of all supplied ColumnDataSources
  2. Restore tool: Restores the cached snapshots in the snapshot tool
  3. Clear tool: Clears all data on the supplied ColumnDataSources
@jbednar
Copy link
Contributor

jbednar commented Aug 8, 2018

Hmm; those are tricky concepts to convey. I'll think about those...

@jbednar
Copy link
Contributor

jbednar commented Aug 8, 2018

This could be Clear:

image

@jbednar
Copy link
Contributor

jbednar commented Aug 8, 2018

Checkpoint:

image

Restore:

image

(I called it Checkpoint rather than Snapshot to avoid conflation with the image Save tool....)

@kcpevey
Copy link
Collaborator

kcpevey commented Aug 8, 2018

My two cents:
Your Checkpoint icon makes me think of moving backward
Your Restore icon makes me think of moving forward.

In reality, the checkpoint is setting the current point as a checkpoint. Which makes me think of just the check mark by itself.

The restore button will be going back to the previous check point, which makes me think of the check mark with the arrow going backward (your checkpoint icon).

@kcpevey
Copy link
Collaborator

kcpevey commented Aug 8, 2018

But I do see value in the two being visually related...

@jbednar
Copy link
Contributor

jbednar commented Aug 8, 2018

The direction of the arrows was to match the undo and redo direction (which is where I got the arrows), but sure, one could just have a check and a restore icon:

Checkpoint:
image

Restore:
image

The right-facing arrow makes a nicer graphic design than this left one, but either is fine with me. I'll leave it up to Philipp.

@kcpevey
Copy link
Collaborator

kcpevey commented Aug 9, 2018

I'm not at all the authority on this, just stating my personal opinion :)

@kajiglet may want to weigh in

@kajiglet
Copy link

kajiglet commented Aug 9, 2018

@jbednar Where can I find the full suite of existing icons to get a overall feel?

I agree that the right-facing arrow would be nicer, however the direction is important since restoring returns the state to an older checkpoint.

@philippjfr
Copy link
Contributor Author

@jbednar Where can I find the full suite of existing icons to get a overall feel?

Here they are.

@kajiglet
Copy link

kajiglet commented Aug 9, 2018

The check symbol could be confused with verification or confirmation. How about a camera:
snapshot
restore

@jbednar
Copy link
Contributor

jbednar commented Aug 10, 2018

The camera icon makes sense with snapshot, but I'd worry that it would be confusing with the save tool (currently a floppy disk icon, as if that meant something to the kids these days!), since that too is a kind of snapshot. Anyway, I have no strong preference between any of them, so maybe leave it up to @bryevdv.

@jbednar
Copy link
Contributor

jbednar commented Aug 10, 2018

Here's the full set of icons, for reference:
image

@bryevdv
Copy link

bryevdv commented Aug 10, 2018

Visual design is not a strength of mine.

My only ideas are that the snapshot tool evidently saves something like a table, so perhaps if it's possible to represent a table in an icon that might be a good choice. Then the table could have a little ✖️ or ✔️ in the corner for the restore/clear versions? And then if all that is possible, the save tool could be changed to the camera (agree that a floppy disk is getting anachronistic, I haven't used one personally in ~15 years)

@jbednar
Copy link
Contributor

jbednar commented Aug 11, 2018

I'm happy to submit a PR to replace the snapshot tool's icon with a camera. :-) I guess even cameras are anachronistic by this point, but arguably so is anything with a physical form that reflects its function!

@philippjfr, how does the clear tool relate to the checkpoint and restore tools? I had been thinking it was separate, in that it doesn't involve the stack of saved state, just the current state, but I guess in each case it's about the state of an object -- clearing it, saving it, and restoring it? Do they each work on one particular CDS, or does clear clear all drawing objects?

In any case, "Table" (presumably like image rather than image?) doesn't particularly convey "state" to me. I thought about a memory chip image, but the issue is that it represents a "store", and here the shared thing across all three tools is not the store (which is relevant only to two of the three tools), it's the state (which is pushed on a store, pulled from a store, or cleared).

So maybe the store can be represented by a stack, like image, with one of the items in the stack hovering over the rest at a bit of a distance? Then the clear icon can put an x on that item (clearing the current state), and a down arrow (towards the stack) would represent "checkpoint" or "snapshot", and an up arrow (from the stack to the current state) would represent restoring from the store?

It's a bit abstract, but seems accurate, at least if my understanding of how the three tools relate to each other is correct.

@kajiglet
Copy link

kajiglet commented May 6, 2019

Let's implement the camera icons for the EarthSim annotators using the customizable icon method (so we don't need to do a Bokeh PR).

@kcpevey kcpevey added wishlist and removed ready labels Oct 19, 2020
@kcpevey kcpevey added this to the Wishlist milestone Oct 19, 2020
@kcpevey kcpevey removed the wishlist label Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants