From 484a5ecc1e36ddc70be2ed2f100e300070c0b624 Mon Sep 17 00:00:00 2001 From: spwoodcock Date: Tue, 7 Jan 2025 23:34:43 +0000 Subject: [PATCH] docs: add note for future fix --- tests/test_parser.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/test_parser.py b/tests/test_parser.py index 36d2017..7b9663e 100644 --- a/tests/test_parser.py +++ b/tests/test_parser.py @@ -34,11 +34,11 @@ def test_polygon_with_holes(polygon_holes_geojson): def test_polygon_merge_with_holes(polygon_holes_geojson): - """A single Polygon with holes, should be merged.""" + """A single Polygon with holes, where the holes should be removed.""" result = parse_aoi(polygon_holes_geojson, merge=True) assert is_featcol_nested_polygon(result) assert len(result["features"]) == 1 - # We have the single exterior ring remaining + # As we specify 'merge', only the exterior ring should be remaining assert len(result["features"][0]["geometry"]["coordinates"]) == 1 @@ -219,7 +219,10 @@ def test_multipolygon_no_merge(multipolygon_geojson): def test_multipolygon_with_holes(multipolygon_holes_geojson): - """MultiPolygon --> Polygon, with no holes.""" + """MultiPolygon --> Polygon, with holes remaining.""" + # FIXME this should not removed the holes from the polygon geom + # FIXME Instead the polygon should simply be extrated from the MultiPolygon + # FIXME (we only remove holes if merge=True) result = parse_aoi(multipolygon_holes_geojson) assert is_featcol_nested_polygon(result) assert len(result["features"]) == 3