Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ssh_port support #3038

Closed
spacegoing opened this issue Aug 24, 2024 · 2 comments · May be fixed by #3366
Closed

Adding ssh_port support #3038

spacegoing opened this issue Aug 24, 2024 · 2 comments · May be fixed by #3366

Comments

@spacegoing
Copy link

spacegoing commented Aug 24, 2024 •
edited
Loading

System Info

`ssh_port` argument is used by deepspeed, current version of hf accelerate missing this argument

Reproduction

argument is missing

Expected behavior

A quick & dirty fix would be at here adding:

accelerate/src/accelerate/utils/launch.py

Line 352 in 726140c

cmd.extend(["--master_port", str(main_process_port)]) 

cmd.extend(["--ssh_port", str(12345678)])
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot closed this as completed Oct 7, 2024
@cyr0930
Copy link

cyr0930 commented Jan 25, 2025

I think this should be supported
or no_ssh option

@cyr0930 cyr0930 mentioned this issue Jan 25, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add deepspeed_ssh_port option to connect ssh with port other than 22 cyr0930/accelerate
2 participants
@spacegoing @cyr0930