Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change editor.js into js.jsx? #15

Open
cqcn1991 opened this issue Jan 30, 2016 · 2 comments
Open

Change editor.js into js.jsx? #15

cqcn1991 opened this issue Jan 30, 2016 · 2 comments

Comments

@cqcn1991
Copy link

Using pagedown-bootstrap is quite easy. However, if I want to customize the toolbar, it becomes problematic, since the entire HTML are written in js (https://github.com/hughevans/pagedown-bootstrap-rails/blob/master/vendor/assets/javascripts/markdown.editor.js.erb#L1381)

I'm wondering if there is any way that I can extract the toolbar out, and make into HTML again? So it would be easier for otheres to see the HTML, or customize it.

Note: I'm not sure whether .jsx would be a good choice, I just put it here to make an example.

@hughevans
Copy link
Owner

Hi @cqcn1991, thanks for the great suggestion. A cursory look makes me think it might be challenging to bind the click events correctly, but we’ll see.

I probably won’t be able to work on it for a couple of weeks, so happy if you want to take a stab at it before then.

@cqcn1991
Copy link
Author

cqcn1991 commented Feb 1, 2016

It's just a small idea, not sure if that is useful so I post it in this issue.
I think this is a very useful gem, Why it seems like it didn't receive too much attention? I did a little bit of search, didn't find other good gem for markdown editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants