Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SymonClient] When there is an unhandled error, Monika didn't send notifications to operator #1178

Closed
dennypradipta opened this issue Nov 14, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@dennypradipta
Copy link
Contributor

This happened when there was an unusual alert query in Symon. The app crashed but there were no notifications sent to the operator regarding Monika is crashed. This is undetected because dockerized Monika has unless-stopped restart policy.

Monika should handle if it crashed, it should send notifications to operator

@dennypradipta
Copy link
Contributor Author

@haricnugraha Might need to reconfirm to you: You said that when there is an error regarding some assertion, it stops Monika?

image

I just tried putting something weird in the assertion, run it both locally and dockerized, it didn't stop the container. Above is the screenshot of running it in Dockerized, without unless-stopped restart policy

@haricnugraha
Copy link
Contributor

@haricnugraha Might need to reconfirm to you: You said that when there is an error regarding some assertion, it stops Monika?

image I just tried putting something weird in the assertion, run it both locally and dockerized, it didn't stop the container. Above is the screenshot of running it in Dockerized, without `unless-stopped` restart policy

Did you use main branch? If so, I've fixed it in pull request 1179.

@haricnugraha haricnugraha added the bug Something isn't working label Nov 16, 2023
@dennypradipta
Copy link
Contributor Author

Ah, figures. It can be closed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants