Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Warp check should assert that contracts are verified #5319

Open
nambrot opened this issue Jan 29, 2025 · 0 comments
Open

CLI Warp check should assert that contracts are verified #5319

nambrot opened this issue Jan 29, 2025 · 0 comments
Assignees

Comments

@nambrot
Copy link
Contributor

nambrot commented Jan 29, 2025

Right now, the warp checker does not check if contracts are verified. This ticket encapsulates that it does. The way to accomplish is recommended as following:

  1. When reading the specified warp deploy configuration (aka the control), extend it to a WarpDeployConfig & WarpCheckVirtualConfig type that includes a object of all contracts and an assertion that their verification status is true
type WarpCheckVirtualConfig = {
  contractVerificationStatus: {
    proxyAdmin: boolean, // true in the control
    hyperc20: boolean,
  }
}
  1. When reading the on-chain configuration, extend it to the same type, but the values are whether the contracts are actually verified

Violations (i.e. ObjectDiffs) are asserted in the differences between these objects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Sprint
Development

No branches or pull requests

2 participants