Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Warp Checker should reference deploy/warpcore config sanely #5320

Open
nambrot opened this issue Jan 29, 2025 · 0 comments
Open

CLI Warp Checker should reference deploy/warpcore config sanely #5320

nambrot opened this issue Jan 29, 2025 · 0 comments
Assignees

Comments

@nambrot
Copy link
Contributor

nambrot commented Jan 29, 2025

Current behavior:

  • warp check reads deploy config from DEFAULT_WARP_ROUTE_DEPLOYMENT_CONFIG_PATH
  • warp check can be configured to read warp deploy config with the --config/-i flag to a file path
  • warp check reads warpcore config from specifying the --symbol flag and if a specific warpCore config couldn't be found, it will give an interactive wizard to pick it
  • warp check can be configured to read warpcore config from the --warp/-wc flag to a file path

Expected behavior:

  • warp check can be configured with a --warpRouteId flag to find both the warpdeploy config (now in the configured registry due to Warp Deploy Config fetching and writing via IRegistry #5237) and the warpcoreconfig
  • when not specified, an interactive wizard should give me the options of all warp route Ids in the specified warp registry. I should be able to use typeahead search to find the warp route that I want
  • individual file paths to --config/-i for warp deploy config and --warp/-wc should still apply, however both have to be given together

Drive-by change:

  • When a completely different warp deploy config (lets say involving chains A and B) is matched with a completely different warpcore config (lets say involving chains C and D), the diff should clearly state: expected: A, B, actual: C, D. Right now it just states expected A, B
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Sprint
Development

No branches or pull requests

2 participants