Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate de-duplicating TokenType and TokenStandard #5328

Open
jmrossy opened this issue Jan 29, 2025 · 0 comments
Open

Investigate de-duplicating TokenType and TokenStandard #5328

jmrossy opened this issue Jan 29, 2025 · 0 comments

Comments

@jmrossy
Copy link
Contributor

jmrossy commented Jan 29, 2025

Problem

The SDK has two important enums for representing the 'kind' of a token:
TokenType
TokenStandard

TokenType came first and is tightly coupled to the different EVM token contracts.

TokenStandard came later to meet the needs of WarpCore and the Warp UI. It must support:

  1. All protocols, not just EVM
  2. Additional standards, not just Hyperlane ones (e.g. IBC)

Two different token types may possibly have the same token standard. Two different token standards must have different token types. This decoupling makes de-duping them tricky. It may be the case that we need to keep both degrees of freedom here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant