Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main branch does not compile #27

Open
haroldcarr opened this issue Jul 3, 2024 · 6 comments
Open

main branch does not compile #27

haroldcarr opened this issue Jul 3, 2024 · 6 comments
Assignees

Comments

@haroldcarr
Copy link
Contributor

> git clone git@github.com:hyperledger/anoncreds-v2-rs.git
Cloning into 'anoncreds-v2-rs'...
...
> cd anoncreds-v2-rs
> cargo test
    Updating crates.io index
    Updating git repository `https://github.com/cryptidtech/bulletproofs`
   Compiling proc-macro2 v1.0.86
   ...
   Compiling bulletproofs v4.0.0 (https://github.com/cryptidtech/bulletproofs#7c5ffd38)
   Compiling credx v0.1.0 (/private/tmp/anoncreds-v2-rs)
error[E0119]: conflicting implementations of trait `From<blsful::inner_types::Scalar>` for type `claim::scalar::ScalarClaim`
  --> src/claim/scalar.rs:34:1
   |
34 | impl From<Scalar> for ScalarClaim {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: conflicting implementation in crate `blstrs_plus`:
           - impl From<blsful::inner_types::Scalar> for <blsful::inner_types::Scalar as ark_ff::fields::prime::PrimeField>::BigInt;

... other similar errors
@swcurran
Copy link
Member

swcurran commented Jul 3, 2024

@mikelodder7 — can you please fix this one ASAP? Thanks. I assume this is from a BLSFul change.

@mikelodder7
Copy link
Contributor

Blsful hasn’t change in months. Must be something else

@swcurran
Copy link
Member

swcurran commented Jul 4, 2024

Do you have any bandwidth to look into it? Perhaps not on July 4, but sometime soon? :-)

@mikelodder7
Copy link
Contributor

Yeah I might today

@haroldcarr
Copy link
Contributor Author

Does this have anything to do with the problem:
2024-07-09

@andrewwhitehead
Copy link
Member

Fix added here: mikelodder7/blstrs#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants