Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the DIDComm protocol implementation in the edge-agent SDK KMP with the DIDComm specification (optional body property) #219

Open
yshyn-iohk opened this issue Jan 28, 2025 · 0 comments

Comments

@yshyn-iohk
Copy link
Member

Is this a regression?

No

Description

All Aried protocols (e.g., issue credentials, present proof, revoke credentials, report a problem, etc.) should be revised according to the DIDCommV2 specification and use the body property of the DIDComm message as an optional field.

Please provide the exception or error you saw

The `body` property of the DIDComm messages must be optional
In the current version, 1.40.0, the `body` is required and contains the nested properties with `null` values.
In the version after 1.40.0, the nested properties with `null` values are dropped, and the `body` is an empty object.
Example of the message: issue-credential/3.0/issue-credential

Please provide the environment you discovered this bug in

DEV

Anything else?

Interoperability with other SSI systems and agents needs to align with the specifications and not send unnecessary properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant