Replies: 2 comments
-
Most of these are questions for the BIS working group. @diegoalexdiaz may be able to help. He may want to schedule a conversation. e.g., are sheet index priorities supposed to be sequential, and is it the job of core-backend to enforce that (somehow?) How do priorities work when one sheet index references another one via SheetIndexReference? SheetIndexFolders have their own priorities, and can contain other SheetIndexEntry's with their own priorities - how do priorities work for folders and down through the folder structure? Re: tests - unless you intend to add multiple files, just put them in src/test/SheetIndex.test.ts. |
Beta Was this translation helpful? Give feedback.
-
I have marked the draft PR mentioned in this discussion as ready for review. I intend to follow it up with another PR in the near future. |
Beta Was this translation helpful? Give feedback.
-
Context:
My team is working on creating features to facilitate the production of 2d drawings and sheets for users using iTwin.js. To do this, we need to be able to insert Sheet Indexes and their relational elements into the iModel. Since there are no Sheet Index TS implementations, we took the initiative and started creating them ourselves.
We have created a draft PR for these TS implementations and have a few questions about it. I feel like larger discussion needs happen and the PR may not be the best place for that. I will include my questions here and hope the right people will see it.
Questions:
a. How to add a BisCodeSpec?
b. Is it needed for use case?
c. What Scope Type is need?
a. Proposed location: core\backend\src\test\sheetIndex\SheetIndex.test.ts
b. How to run tests for specific files, because running all backend tests takes long (Figured it out:
describe.only(....)
) .Beta Was this translation helpful? Give feedback.
All reactions