Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree widget: Unable to use ModelsTreeComponent.ToggleInstancesFocusButton outside of ModelsTreeComponent #1173

Closed
grigasp opened this issue Feb 3, 2025 · 2 comments · Fixed by #1175
Closed

Tree widget: Unable to use ModelsTreeComponent.ToggleInstancesFocusButton outside of ModelsTreeComponent #1173

grigasp opened this issue Feb 3, 2025 · 2 comments · Fixed by #1175
Assignees
@grigasp
Labels
bug Something isn't working tree widget Tree widget or its components related issues

Comments

@grigasp
Copy link
Member

grigasp commented Feb 3, 2025

The button uses focusedInstancesContext, which is provided by ModelsTreeComponent and is not available when the button is used outside of the component. We should look into exposing FocusedInstancesContextProvider to consumers.
@grigasp grigasp added bug Something isn't working tree widget Tree widget or its components related issues labels Feb 3, 2025
@grigasp grigasp mentioned this issue Feb 3, 2025
Open
@grigasp grigasp self-assigned this Feb 3, 2025
@grigasp grigasp mentioned this issue Feb 3, 2025
Merged
@grigasp
Copy link
Member Author

grigasp commented Feb 4, 2025

The change has been released with version 3.4:

  • Expose FocusedInstancesContextProvider and useFocusedInstancesContext to allow using ModelsTreeComponent.ToggleInstancesFocusButton from outside of ModelsTreeComponent and accesing the context from other React components. (#1175)

@ValdasSorys, please see if that resolves your problem, I'll keep this work item open until you do.

@grigasp grigasp reopened this Feb 4, 2025
@ValdasSorys
Copy link

@grigasp This resolves my problem

@grigasp grigasp closed this as completed Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grigasp grigasp

Labels
bug Something isn't working tree widget Tree widget or its components related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tree widget: Expose focused instances context provider iTwin/viewer-components-react
2 participants
@grigasp @ValdasSorys