Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment Settings #22

Open
tzahush opened this issue Apr 3, 2019 · 3 comments
Open

Environment Settings #22

tzahush opened this issue Apr 3, 2019 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@tzahush
Copy link

tzahush commented Apr 3, 2019

Hello,

Is there anyway of setting it up as such that the plugin could use the AWS environment settings on the device, so i wont have to put in my Access Key and Secret Key?

@iann0036
Copy link
Owner

iann0036 commented Apr 3, 2019

Not currently. I'll have to look into it. I think I was previously concerned with sandboxing, so I'm not 100% sure whether or not it'll actually be possible.

@justinclayton
Copy link

While sandboxing is a noble goal, it does hamper the functionality of this extension for anyone who uses federation instead of static credentials (a best practice in most enterprises).

If you're looking for permission, it appears that the official AWS Toolkit for VS Code doesn't seem to mind grabbing the config files from the user's filesystem: https://github.com/aws/aws-toolkit-vscode/blob/ab650f54d0a4526aadcbff2979136f27ba735717/src/shared/credentials/credentialsFile.ts#L61-L85

@iann0036
Copy link
Owner

iann0036 commented May 3, 2020

Hey @justinclayton,

Thanks for the reference, it's very helpful.

I'll try to find some time to implement this into a future version, though I can't commit to a specific time.

@iann0036 iann0036 added the help wanted Extra attention is needed label May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants