Prevent code execution in Directives ctor's #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meerownymous
suggested changes
Dec 28, 2018
|
@Meerownymous |
…Add only additional ctor
Meerownymous
suggested changes
Apr 23, 2020
| public Directives(String text) : this(Directives.Parse(text)) | ||
| /// <param name="xambly">Xambly script</param> | ||
| public Directives(IText xambly) : this( | ||
| new StickyScalar<ICollection<IDirective>>(() => |
There was a problem hiding this comment.
should be a Solid to ensure threadsafeness.
| /// <param name="items">list to instantiate from</param> | ||
| public ThreadsafeCollection(IEnumerable<T> items) | ||
| { | ||
| if (items == null) |
There was a problem hiding this comment.
code execution in ctor
| /// <param name="items">list to instantiate from</param> | ||
| public ThreadsafeCollection(IEnumerable<T> items) | ||
| { | ||
| if (items == null) |
There was a problem hiding this comment.
ctor should be placed in a lock statement
|
Closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?** (check one with "x")
What is the current behavior? (You can also link to an open issue here)
close #133
What is the new behavior?
Directives()ctor'sDoes this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications
Other information