Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adventure map, treasure chest does not offer exp when hero has no space for an artifact #9546

Open
2 tasks done
Branikolog opened this issue Feb 10, 2025 · 0 comments · May be fixed by #9607
Open
2 tasks done

Adventure map, treasure chest does not offer exp when hero has no space for an artifact #9546

Branikolog opened this issue Feb 10, 2025 · 0 comments · May be fixed by #9607
Labels
good first issue Good for newcomers improvement New feature, request or improvement logic Things related to game logic
Milestone
1.1.7

Comments

@Branikolog
Copy link
Collaborator

Preliminary checks

Platform

Windows

Describe the bug

When trying to pick up the treasure chest containing an artifact instead of gold - game offers just a gold showing uncommon dialog:

Image

Image

For tha case of full hero the chest should offer a standard gold/exp choosing window.
The original game shows standard dialog for this case.
Offering the gold only looks like something is not normal here.

Save file

Chest Issue gold.zip

Additional info

No response
@Branikolog Branikolog added the logic Things related to game logic label Feb 10, 2025
@Branikolog Branikolog added this to the 1.1.7 milestone Feb 10, 2025
@ihhub ihhub added improvement New feature, request or improvement good first issue Good for newcomers labels Feb 11, 2025
roman-yagodin added a commit to roman-yagodin/fheroes2 that referenced this issue Mar 4, 2025
@roman-yagodin
ihhubGH-9546 Replace "gold only" chest dialog with "gold or exp" one
908ebc1 
in case when hero has no space for an artifact
roman-yagodin added a commit to roman-yagodin/fheroes2 that referenced this issue Mar 5, 2025
@roman-yagodin
ihhub#9546 Extract method to avoid code duplication
1df74da
@roman-yagodin roman-yagodin linked a pull request Mar 5, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement New feature, request or improvement logic Things related to game logic
Projects
None yet
Milestone
1.1.7
2 participants
@ihhub @Branikolog