Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: auto dark mode wrong behavior #147

Closed
1 task done
rainbowflesh opened this issue May 5, 2024 · 10 comments
Closed
1 task done

[Bug]: auto dark mode wrong behavior #147

rainbowflesh opened this issue May 5, 2024 · 10 comments
Labels
bug Something isn't working triage Cause of the issue needs to be triaged

Comments

@rainbowflesh
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

QQ截图20240505182958

  1. When system change to light/dark mode with VS Code running, extension will notify theme changed and pop up reload dialog; but after restart, the "config is changed" dialog will pop up again with change back to opposite theme.
  2. When system change to light/dark mode without VS Code running, extension won't prompt change to light/dark mode.

Expected Behavior

A light/dark mode check after VS Code start up will help?

Steps To Reproduce

  1. close vscode.
  2. change system theme.
  3. run vscode.

Environment

- OS: win11
- VSCode: newest release
- Extension: alot
- Theme: rosepine

Anything else?

{
"vscode_vibrancy.theme":"light",
"vscode_vibrancy.preferedLightTheme":"light",
"vscode_vibrancy.preferedDarkTheme":"dark",
"window.autoDetectColorScheme":true
}
@rainbowflesh rainbowflesh added bug Something isn't working triage Cause of the issue needs to be triaged labels May 5, 2024
@MrOxMasTer
Copy link

The github theme is breaking too

image

@LiPingYen
Copy link

The solarized dark + is broken.

CleanShot 2024-05-05 at 20 58 49@2x

@zedle
Copy link

zedle commented May 5, 2024

Same here with Catppuccin Mocha. If I set the theme again it will work until I load a new folder, reload the workspace, or restart vscode, then it breaks again.

@Fefedu973
Copy link

Same

@LouisRaverdy
Copy link

Same issue here, the only workaround is downgrading the version on install.
Waiting for a fix

@illixion
Copy link
Owner

illixion commented May 5, 2024

Apologies all, pushed some faulty code, version .31 has the fix

@illixion illixion closed this as completed May 5, 2024
@LouisRaverdy
Copy link

Nice ! Thank you for your great extension !

@illixion
Copy link
Owner

illixion commented May 5, 2024

The Vibrancy theme setting needs to be restored to what it was before as the previous value would've been lost, unfortunately

@Fefedu973
Copy link

The Vibrancy theme setting needs to be restored to what it was before as the previous value would've been lost, unfortunately

Yup. Only issue. It seems that now the window control isn't working (cannot click on the maximize button and cannot snap the window on the sides)

@illixion
Copy link
Owner

illixion commented May 7, 2024

Yup. Only issue. It seems that now the window control isn't working (cannot click on the maximize button and cannot snap the window on the sides)

If you’re on Windows, you may be encountering this bug: #140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Cause of the issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

7 participants