Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShrineS3 url needs to be configurable? #34

Open
mateomurphy opened this issue Feb 11, 2020 · 1 comment
Open

ShrineS3 url needs to be configurable? #34

mateomurphy opened this issue Feb 11, 2020 · 1 comment

Comments

@mateomurphy
Copy link

In my shrine setup, the S3 urls are in the format "s3://#{image.storage.bucket.name}/store/#{image.id}". I've overridden Imgproxy::UrlAdapters::ShrineS3#url to customize this, but perhaps it would be a good idea to make this configurable?
@DarthSim
Copy link
Member

The gem didn't use Shrine's prefix. Fixed in 1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mateomurphy @DarthSim