Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[💄Feature]: Separate code from JSDOC types. #10

Open
2 tasks done
wiseaidev opened this issue Mar 12, 2023 · 0 comments
Open
2 tasks done

[💄Feature]: Separate code from JSDOC types. #10

wiseaidev opened this issue Mar 12, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wiseaidev
Copy link
Collaborator

👶 Getting Started
Please search the history to see if an issue already exists for the same problem.

  • I have searched the existing issues.
  • I have tested the latest version.

📝 Describe the feature
The following line of code is a prime example why we should separate code from types:

https://github.com/wiseaidev/flexify/blob/07b43237c134512f23e4e993b5e54da883a5fd82/scripts/popup.js#L315

Therefore, we should have a separate file to store all the types, namely types.js under the script folder that contains all type definitions, and then load them into the script.

📸 Screenshots
N/A

🔦 Context
N/A

@wiseaidev wiseaidev added enhancement New feature or request good first issue Good for newcomers labels Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant