Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[💄Feature]: Separate code from data. #15

Open
2 tasks done
wiseaidev opened this issue Mar 13, 2023 · 0 comments
Open
2 tasks done

[💄Feature]: Separate code from data. #15

wiseaidev opened this issue Mar 13, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wiseaidev
Copy link
Collaborator

👶 Getting Started
Please search the history to see if an issue already exists for the same problem.

  • I have searched the existing issues.
  • I have tested the latest version.

📝 Describe the feature
The popup.js file is quite messy, containing a blend of data, code, and CSS. It would be better to apply separation of concerns and things of that nature, for the long-term maintainability.

📸 Screenshots
N/A

🔦 Context

For example, the following object could be stored in a json file under the data folder, and load it with fetch, like what I did in tts:

https://github.com/wiseaidev/flexify/blob/1b82d3c65f224f8ada93c183ed682cff3315f6c5/scripts/popup.js#L440-L542

https://github.com/wiseaidev/flexify/blob/1b82d3c65f224f8ada93c183ed682cff3315f6c5/scripts/text-to-speech.js#L17-L21

@wiseaidev wiseaidev assigned wiseaidev and unassigned wiseaidev Mar 13, 2023
@wiseaidev wiseaidev added enhancement New feature or request good first issue Good for newcomers labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant