You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The options being passed to scipy solvers here and here should be refactored into their own pydantic classes, as is done for the Nevergrad solvers here. In other words, the initializers of ScipyDeSolver and ScipyMinimizeSolver should have the following structure:
where ScipyDeOptions and ScipyMinimizeOptions should be instances of new pydantic classes. For guidance on how these should look like, see here. Default options should also be defined as their own instances of these new classes (such as is done here).
Writing also a couple tests more for the two scipy solvers would not hurt.
The text was updated successfully, but these errors were encountered:
The options being passed to scipy solvers here and here should be refactored into their own pydantic classes, as is done for the Nevergrad solvers here. In other words, the initializers of
ScipyDeSolver
andScipyMinimizeSolver
should have the following structure:where
ScipyDeOptions
andScipyMinimizeOptions
should be instances of new pydantic classes. For guidance on how these should look like, see here. Default options should also be defined as their own instances of these new classes (such as is done here).Writing also a couple tests more for the two scipy solvers would not hurt.
The text was updated successfully, but these errors were encountered: