Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring scipy solver options into their own pydantic models #95

Open
gialmisi opened this issue Apr 25, 2024 · 0 comments
Open

Refactoring scipy solver options into their own pydantic models #95

gialmisi opened this issue Apr 25, 2024 · 0 comments
Labels
help wanted restructuring Label for the DESDEO restructuring project

Comments

@gialmisi
Copy link
Contributor

The options being passed to scipy solvers here and here should be refactored into their own pydantic classes, as is done for the Nevergrad solvers here. In other words, the initializers of ScipyDeSolver and ScipyMinimizeSolver should have the following structure:

def __init__(self, problem: Problem, options: ScipyDeOptions):
    ...

def __init__(self, problem: Problem, options: ScipyMinimizeOptions):
    ...

where ScipyDeOptions and ScipyMinimizeOptions should be instances of new pydantic classes. For guidance on how these should look like, see here. Default options should also be defined as their own instances of these new classes (such as is done here).

Writing also a couple tests more for the two scipy solvers would not hurt.

@gialmisi gialmisi added help wanted restructuring Label for the DESDEO restructuring project labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted restructuring Label for the DESDEO restructuring project
Projects
None yet
Development

No branches or pull requests

1 participant