Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: conclude the consensus overview.md documentation #761

Open
6 tasks done
Tracked by #367
cason opened this issue Jan 14, 2025 · 2 comments
Open
6 tasks done
Tracked by #367

spec: conclude the consensus overview.md documentation #761

cason opened this issue Jan 14, 2025 · 2 comments
Labels
spec Related to specifications

Comments

@cason
Copy link
Contributor

cason commented Jan 14, 2025

The Tendermint consensus algorithm overview contains somehow our interpretation of the Tendermint paper and the associated implementation of the algorithm. It should not, however, dive into our implementation details.

However, it has some missing part and some TODOs:

@cason cason added the spec Related to specifications label Jan 14, 2025
@cason
Copy link
Contributor Author

cason commented Jan 14, 2025

As also pointed out by @josef-widder, this document that should be an "overview" is getting super long and complex.

We should consider splitting it into parts, once its "full content" is defined.

@cason
Copy link
Contributor Author

cason commented Jan 14, 2025

Another point to consider is the absence in the pseudo-code and the description of the algorithm in general of a decision primitive, to deliver decide values to the context/application.

The decision is achieved by appending to the decision_p array the decided value, the array being indexed by heights. This behavior is described in this section, but the actual interface with the context/application is not discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec Related to specifications
Projects
None yet
Development

No branches or pull requests

1 participant